Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vue-vapor #1744

Merged
merged 2 commits into from
Sep 24, 2024
Merged

update vue-vapor #1744

merged 2 commits into from
Sep 24, 2024

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Sep 19, 2024

Vue Vapor's performance has improved.

@sxzz sxzz marked this pull request as draft September 19, 2024 08:44
@sxzz sxzz marked this pull request as ready for review September 22, 2024 05:22
@krausest krausest merged commit 212a3bb into krausest:master Sep 24, 2024
@krausest
Copy link
Owner

Here's a screenshot from an incremental run (left new version, right old version).
Please note that vanillajs was slower on the left. I'm a bit disappointed with that because I'm trying to solve #1721, but as you can see vanillajs perfomed was 0.2 slower (even after reboot and on AC). So I think it's plausible to assume that performance for all updated versions would be better in a full run. Vue-vapor was faster even under those circumstances.
Screenshot 2024-09-25 at 08 05 07

@sxzz sxzz deleted the update-vue-vapor branch September 25, 2024 07:16
@antonmak1
Copy link
Contributor

@sxzz Hi! It's really cool that you're promoting a topic without VDOM! I was so blown away by this comment, like VDOM isn't crap, that it's fast, it's just that js-framework-benchmark is a disgrace that it's being compared to it in terms of speed. It's just mind-blowing.

@antonmak1
Copy link
Contributor

antonmak1 commented Oct 29, 2024

@sxzz Like, I just came across this comment from @gaearon and was just shocked. https://x.com/dan_abramov2/status/1796156983575232942

@antonmak1
Copy link
Contributor

@krausest It turns out that the benchmark is crap, that's how it is, it doesn't show the speed. It's a shame what we're doing. I'm just shocked. This stinking VDOM is being promoted to the masses tightly, then billions of people load the site a second or two faster, and that's millions of years of time saved for people.

@antonmak1
Copy link
Contributor

For convenience, people simply waste millions of seconds of time that could be saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants