Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vue-vapor #1744

Merged
merged 2 commits into from
Sep 24, 2024
Merged

update vue-vapor #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a77d147
update vue-vapor
sxzz Sep 19, 2024
8a602a3
chore: update
sxzz Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
751 changes: 242 additions & 509 deletions frameworks/keyed/vue-vapor/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions frameworks/keyed/vue-vapor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@
"preview": "vite preview"
},
"dependencies": {
"vue": "npm:@vue-vapor/vue@latest"
"vue": "https://pkg.pr.new/vuejs/core-vapor/vue@e07eac9"
},
"devDependencies": {
"@vitejs/plugin-vue": "npm:@vue-vapor/vite-plugin-vue@latest",
"vite": "^5.2.9",
"vite-plugin-inspect": "^0.8.5"
"@vitejs/plugin-vue": "https://pkg.pr.new/@vitejs/plugin-vue@d8e849f",
"vite": "^5.4.6"
}
}
918 changes: 0 additions & 918 deletions frameworks/keyed/vue-vapor/pnpm-lock.yaml
View file
Open in desktop

This file was deleted.

24 changes: 11 additions & 13 deletions frameworks/keyed/vue-vapor/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script setup vapor>
import { ref, shallowRef, triggerRef, watch } from "vue";
import { ref, shallowRef, triggerRef } from "vue";
import { createSelector } from "vue/vapor";
import { buildData } from "./data";

const selected = ref();
Expand Down Expand Up @@ -51,20 +52,11 @@ function swapRows() {
const d998 = _rows[998];
_rows[1] = d998;
_rows[998] = d1;
triggerRef(rows)
triggerRef(rows);
}
}

// Reduce the complexity of `selected` from O(n) to O(1).
function createSelector(source) {
const cache = {}
watch(source, (val, old) => {
if (old != undefined) cache[old].value = false
if (val != undefined) cache[val].value = true
})
return id => (cache[id] ??= shallowRef(false)).value
}
const isSelected = createSelector(selected)
const isSelected = createSelector(selected);
</script>

<template>
Expand Down Expand Up @@ -103,7 +95,13 @@ const isSelected = createSelector(selected)
</div>
<table class="table table-hover table-striped test-data">
<tbody>
<tr v-for="row of rows" :key="row.id" :class="{ danger: isSelected(row.id) }" :data-label="row.label">
<tr
v-for="row of rows"
:key="row.id"
:class="{ danger: isSelected(row.id) }"
:data-label="row.label.value"
v-memo="[row.label.value, row.id === selected]"
>
<td class="col-md-1">{{ row.id }}</td>
<td class="col-md-4">
<a @click="select(row.id)">{{ row.label.value }}</a>
Expand Down
3 changes: 1 addition & 2 deletions frameworks/keyed/vue-vapor/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { defineConfig } from "vite";
import vue from "@vitejs/plugin-vue";
import Inspect from 'vite-plugin-inspect'

export default defineConfig({
plugins: [vue(), Inspect()],
plugins: [vue()],
build: {
rollupOptions: {
input: "src/main.js",
Expand Down
Loading