Skip to content

🌱 e2e: adjust templates to use AWSClusterRoleIdentities per Cluster #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

🌱 e2e: adjust templates to use AWSClusterRoleIdentities per Cluster #5773

merged 1 commit into from
Nov 28, 2025
+32 −32

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 27, 2025

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Fixes the perma-failing / flaking test: capa-e2e.[It] [unmanaged] [functional] Multitenancy test should create cluster with nested assumed role

This happens because we have multiple tests using the same AWSClusterRoleIdentity, and if it got created 15 mins before the test started the credentials are not valid anymore.

Testgrid: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-aws#periodic-e2e-main

k8s-triage to see this is resolved after merging: https://storage.googleapis.com/k8s-triage/index.html?job=periodic-cluster-api-provider-aws-e2e&test=Multitenancy%20test%20should%20create%20cluster%20with%20nested%20assumed%20role

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fix e2e templates to create an `AWSClusterRoleIdentity` per Cluster

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 27, 2025

/test help

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

chrischdi commented Nov 27, 2025

/test pull-cluster-api-provider-aws-e2e

@chrischdi chrischdi force-pushed the pr-clusterroleidentity-per-test branch from f767811 to 6d69af2 Compare November 27, 2025 14:24
@chrischdi
Copy link
Member Author

chrischdi commented Nov 27, 2025

/test pull-cluster-api-provider-aws-e2e

@chrischdi
Copy link
Member Author

chrischdi commented Nov 27, 2025

/retest

@chrischdi chrischdi force-pushed the pr-clusterroleidentity-per-test branch from 6d69af2 to 8b060c8 Compare November 27, 2025 21:21
@chrischdi
Copy link
Member Author

chrischdi commented Nov 27, 2025

/test pull-cluster-api-provider-aws-e2e

damdo
damdo reviewed Nov 28, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the investigation and discovery, this was a long standing one

/assign @richardcase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

LGTM label has been added.

Git tree hash: 2c1dfe2ca590a070889fb581867b42df69fb8e38

@richardcase
Copy link
Member

richardcase commented Nov 28, 2025

Excellent thanks @chrischdi

/approve
/cherrypick release-2.9

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 28, 2025

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

Excellent thanks @chrischdi

/approve
/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 45c7a2e into kubernetes-sigs:main Nov 28, 2025
19 checks passed
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 28, 2025

@richardcase: new pull request created: #5776

In response to this:

Excellent thanks @chrischdi

/approve
/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@richardcase richardcase

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chrischdi @k8s-ci-robot @richardcase @k8s-infra-cherrypick-robot @damdo