Skip to content

[release-2.9] 🌱 e2e: adjust templates to use AWSClusterRoleIdentities per Cluster #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-2.9
Choose a base branch
from
Open

[release-2.9] 🌱 e2e: adjust templates to use AWSClusterRoleIdentities per Cluster #5776

wants to merge 1 commit into from
+32 −32

Conversation

@k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Nov 28, 2025

This is an automated cherry-pick of #5773

/assign richardcase

Fix e2e templates to create an `AWSClusterRoleIdentity` per Cluster

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 28, 2025
Merged
5 tasks
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from damdo November 28, 2025 10:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2025
damdo
damdo reviewed Nov 28, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @chrischdi @richardcase @nrb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

LGTM label has been added.

Git tree hash: 6b3ebe1efaab1579d94deed971023fa6c0d61b97

@damdo
Copy link
Member

damdo commented Nov 28, 2025

/test ?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2025

@damdo: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build-docker-release-2-9

/test pull-cluster-api-provider-aws-build-release-2-9

/test pull-cluster-api-provider-aws-test-release-2-9

/test pull-cluster-api-provider-aws-verify-release-2-9

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-release-2-9

/test pull-cluster-api-provider-aws-e2e-blocking-release-2-9

/test pull-cluster-api-provider-aws-e2e-conformance-release-2-9

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-2-9

/test pull-cluster-api-provider-aws-e2e-eks-release-2-9

/test pull-cluster-api-provider-aws-e2e-eks-testing-release-2-9

/test pull-cluster-api-provider-aws-e2e-release-2-9

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-release-2-9

pull-cluster-api-provider-aws-build-docker-release-2-9

pull-cluster-api-provider-aws-build-release-2-9

pull-cluster-api-provider-aws-test-release-2-9

pull-cluster-api-provider-aws-verify-release-2-9

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Nov 28, 2025

/test pull-cluster-api-provider-aws-e2e-release-2-9

3 similar comments
@damdo
Copy link
Member

damdo commented Nov 28, 2025

/test pull-cluster-api-provider-aws-e2e-release-2-9

@damdo
Copy link
Member

damdo commented Nov 28, 2025

/test pull-cluster-api-provider-aws-e2e-release-2-9

@damdo
Copy link
Member

damdo commented Nov 28, 2025

/test pull-cluster-api-provider-aws-e2e-release-2-9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

Assignees

@richardcase richardcase

@nrb nrb

@chrischdi chrischdi

@damdo damdo

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@k8s-infra-cherrypick-robot @k8s-ci-robot @damdo @richardcase @nrb @chrischdi