- 
                Notifications
    You must be signed in to change notification settings 
- Fork 453
charts/headlamp: Fix for pluginctl without global install #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8af7a4f    to
    8e36091      
    Compare
  
    8e36091    to
    e9fd227      
    Compare
  
    e9fd227    to
    20bb65f      
    Compare
  
    | @yolossn please review? | 
| @illume I tried reproducing this in helm playground. | 
Because there is no permission to do that now. So we run it without installing it. Also make sure the config and cache folders use somewhere writable. The ConfigMap was rendering with extra newlines. At the top, and after plugin.yml, which was causing an error when validating the configuration inside the plugin manager code.
20bb65f    to
    6e36926      
    Compare
  
    | @yolossn Thanks for testing and the review. 
 Neat tool. I updated the config so it does not render with the new lines. Could you please have a look? | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, yolossn The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
| 
 Sorry, yes... this is because we need the watch config which I forgot to mention in the testing. But it's documented already. | 
| Thanks @yolossn | 





Because there is no permission to do that now. So we run it without installing it.
For
Testing
Enable plugin manager:
Put in values.yml
Use the local chart instead of the one in the repo.
kubectl get pods -n headlampmy-headlamp-58789b6df-8cpwn 2/2 Running 0 0m11s.kubectl logs <pod> -c headlamp-pluginThere should be a success message not a failure one.