Skip to content

charts/headlamp: Fix for pluginctl without global install #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
+14 −11
Merged

charts/headlamp: Fix for pluginctl without global install #4094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions charts/headlamp/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,13 +327,15 @@ spec:
{{- end }}
args:
- |
echo "Installing headlamp-plugin globally..."
npm install -g @headlamp-k8s/pluginctl@{{ .Values.pluginsManager.version }}
echo "Installed headlamp-plugin successfully."
if [ -f "/config/plugin.yml" ]; then
echo "Installing plugins from config..."
cat /config/plugin.yml
pluginctl install --config /config/plugin.yml --folderName {{ .Values.config.pluginsDir }} --watch
# Use a writable cache directory
export NPM_CONFIG_CACHE=/tmp/npm-cache
# Use a writable config directory
export NPM_CONFIG_USERCONFIG=/tmp/npm-userconfig
mkdir -p /tmp/npm-cache /tmp/npm-userconfig
npx --yes @headlamp-k8s/pluginctl@{{ .Values.pluginsManager.version }} install --config /config/plugin.yml --folderName {{ .Values.config.pluginsDir }} --watch
fi
volumeMounts:
- name: plugins-dir
Expand Down
5 changes: 2 additions & 3 deletions charts/headlamp/templates/plugin-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.pluginsManager.enabled }}
{{- if .Values.pluginsManager.enabled -}}
apiVersion: v1
kind: ConfigMap
metadata:
Expand All @@ -7,6 +7,5 @@ metadata:
labels:
{{- include "headlamp.labels" . | nindent 4 }}
data:
plugin.yml: |
{{ .Values.pluginsManager.configContent | nindent 4 }}
plugin.yml: |{{ .Values.pluginsManager.configContent | nindent 4 }}
{{- end }}
10 changes: 6 additions & 4 deletions charts/headlamp/tests/expected_templates/security-context.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,15 @@ spec:
command: ["/bin/sh", "-c"]
args:
- |
echo "Installing headlamp-plugin globally..."
npm install -g @headlamp-k8s/[email protected]
echo "Installed headlamp-plugin successfully."
if [ -f "/config/plugin.yml" ]; then
echo "Installing plugins from config..."
cat /config/plugin.yml
pluginctl install --config /config/plugin.yml --folderName /headlamp/plugins --watch
# Use a writable cache directory
export NPM_CONFIG_CACHE=/tmp/npm-cache
# Use a writable config directory
export NPM_CONFIG_USERCONFIG=/tmp/npm-userconfig
mkdir -p /tmp/npm-cache /tmp/npm-userconfig
npx --yes @headlamp-k8s/[email protected] install --config /config/plugin.yml --folderName /headlamp/plugins --watch
fi
volumeMounts:
- name: plugins-dir
Expand Down
Loading