-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable tolerance for Horizontal Pod Autoscalers #4951
Comments
/sig autoscaling |
If we plan for this KEP to land in 1.33, there are a few more steps needed to be completed: https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval |
/label lead-opted-in |
@gjtempleton: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/milestone v1.33 |
Hey @jm-franc,
My main worry is the Production Readiness Review. I'm not too familiar with the process, and I think the deadline is soon. |
Thanks Adrian! I sent #5094 and |
Perfect, thanks! |
Hello @jm-franc 👋, v1.33 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. This enhancement is targeting stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Thank you @fykaa ! I've submitted the PRR questionnaire that marks this feature as 'implementable' for review (#5094) and I hope to have it approved before the deadline. Fingers crossed :) Thank you, |
Hi @jm-franc 👋, 1.33 Enhancements team here, Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. The current status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Hello @jm-franc 👋, 1.33 Enhancements team here. Now that PR #5094 has been merged, all the KEP requirements are in place and merged into k/enhancements. Before the enhancement freeze, it would be appreciated if following nit could be addressed:
Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is now marked as /label tracked/yes |
Done & thank you Dipesh! |
Hello @jm-franc 👋, v1.33 Docs Lead here. Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Thank you Ryan, will do! There are indeed updates required to the documentation. |
Hey @rayandas , I've created the website update draft PR as requested: kubernetes/website#49826 |
Hi @jm-franc 👋 -- this is Agustina (@aibarbetta) from the 1.33 Communications Team! For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement! As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:
To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚 Tip Some timeline to keep in mind:
Note In your placeholder PR, use |
Hey again @jm-franc 👋, v1.33 Enhancements team here, Just checking in as we approach Code Freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP): Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status. If you anticipate missing code freeze, you can file an exception request in advance. The status of this enhancement is marked as As always, we are here to help if any questions come up. Thanks! |
Hi @jm-franc 👋, 1.33 Communications Team here again! This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against Tip Some timeline to keep in mind:
Note In your placeholder PR, use |
Hey, thanks Agustina! I've opened kubernetes/website#50000 |
Hi & thanks @fykaa
I've submitted the PR implementing this feature for review: kubernetes/kubernetes#130797 I hope this will be approved before the code freeze deadline, but please tell me if you think it would be prudent to file an exemption. |
Hi @jm-franc 👋, v1.33 Enhancements team here, Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. The current status of this enhancement is marked as If you anticipate missing code freeze, you can file an exception request in advance. Thank you! |
Thanks Dipesh. The PR has been LGTMed by a SIG TL, and the SIG lead only had a few comments, so hopefully this will be ready to merge by the deadline tomorrow. My main concern is that we touch files that are not owned by sig-autoscaling; those changes are probably non-controversial but still I need to get manage to get approval. |
Hello @jm-franc 👋, v1.33 Enhancements team here, Unfortunately, the implementation (code-related) PRs associated with this enhancement are not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.33 milestone. An exception request has been received (https://groups.google.com/g/kubernetes-sig-release/c/wgcvmhAK75I) and is currently under evaluation. During this review period, the milestone has been removed. Depending on whether the request is approved or rejected, the milestone will be re-added accordingly. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks! /milestone clear |
Hello @jm-franc 👋, v1.33 Enhancements team here, The release team has APPROVED the exception request here, so this KEP is now set to be added to the v1.33 release. The updated deadline to merge all related PRs is 8:00 PM PDT on Tuesday, March 25, 2025. If you have any questions, feel free to reach out in the Exception Request thread on Slack in the #sig-release channel - we’re happy to help. Also, once the code PRs are merged, please feel free to let us know here. Thanks! |
@jm-franc With implementation PR kubernetes/kubernetes#130797 merged. This enhancement is now marked as /milestone v1.33 |
/assign jm-franc |
Enhancement Description
k/enhancements
) update PR(s): KEP-4951: Configurable tolerance for HPA #4954 KEP-4951: Fill PRR questionnaire #5094k/k
) update PR(s): Add support for HPA configurable tolerance kubernetes#130797k/website
) update PR: Add documentation for configurable autoscaling tolerance. website#49826 (Blog post PR)Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: