Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4951: Fill PRR questionnaire #5094

Merged
merged 7 commits into from
Feb 12, 2025
Merged

KEP-4951: Fill PRR questionnaire #5094

merged 7 commits into from
Feb 12, 2025

Conversation

jm-franc
Copy link
Contributor

Add files needed to start the PRR process.

Issue link.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Jan 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jm-franc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2025
@jm-franc
Copy link
Contributor Author

/cc @deads2k

@k8s-ci-robot k8s-ci-robot requested a review from deads2k January 27, 2025 23:54
@jm-franc
Copy link
Contributor Author

/assign @gjtempleton

@jm-franc
Copy link
Contributor Author

/hold

[To ensure this isn't automatically merged before both PRR and SIG lead reviewed.]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@jm-franc jm-franc mentioned this pull request Jan 28, 2025
Open
4 tasks
@adrianmoisey adrianmoisey mentioned this pull request Jan 28, 2025
Closed
@adrianmoisey
Copy link
Member

LGTM

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2025
@raywainman
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2025
gjtempleton
gjtempleton reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@gjtempleton gjtempleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions from me.

@jm-franc jm-franc changed the title KEP-4951: Add PRR file. KEP-4951: Fill PRR questionnaire Jan 31, 2025
@gjtempleton
Copy link
Member

From a SIG point of view:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@adrianmoisey
Copy link
Member

/assign deads2k

soltysh
soltysh reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor bits, ping me when you get them updated so we can approve asap :-)

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 10, 2025
@jm-franc
Copy link
Contributor Author

ping me when you get them updated so we can approve asap :-)

Ping @soltysh :)

soltysh
soltysh approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
PRR

@jm-franc
Copy link
Contributor Author

please ask for approval from gjtempleton

@gjtempleton you provided an LGTM, but would you provide an approval if this looks ok to you? This is the last requirement preventing this PR to be merged (and for this feature to be included in 1.33 :) ) iiuc.

@gjtempleton
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, jm-franc, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@raywainman
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@jm-franc
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8eded88 into kubernetes:master Feb 12, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raywainman raywainman raywainman left review comments

@gjtempleton gjtempleton gjtempleton left review comments

@soltysh soltysh soltysh approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@raywainman raywainman

@gjtempleton gjtempleton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
7 participants
@jm-franc @k8s-ci-robot @adrianmoisey @raywainman @gjtempleton @soltysh @deads2k