Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for configurable autoscaling tolerance. #49826

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Add documentation for configurable autoscaling tolerance. #49826

merged 2 commits into from
Apr 7, 2025
+46 −5

Conversation

jm-franc
Copy link
Contributor

@jm-franc jm-franc commented Feb 18, 2025 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @jm-franc!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2964572
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e40332cfe2450008e84e64

@jm-franc jm-franc mentioned this pull request Feb 18, 2025
Open
4 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2964572
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e4033242bc490008dfa46c
😎 Deploy Preview https://deploy-preview-49826--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jm-franc jm-franc mentioned this pull request Mar 4, 2025
Merged
@rayandas
Copy link
Member

Hello @jm-franc 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@jm-franc jm-franc force-pushed the kep-4951-autoscaling-configurable-tolerance branch 2 times, most recently from 1c32e09 to 153e9be Compare March 25, 2025 15:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2025
@jm-franc jm-franc force-pushed the kep-4951-autoscaling-configurable-tolerance branch from 153e9be to f9aef6d Compare March 25, 2025 17:20
@jm-franc jm-franc marked this pull request as ready for review March 25, 2025 17:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@jm-franc
Copy link
Contributor Author

jm-franc commented Mar 25, 2025 •
edited
Loading

Hello @jm-franc 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

Thank you Ryan! This PR is ready for review!

@raywainman @gjtempleton FYI

@jm-franc jm-franc force-pushed the kep-4951-autoscaling-configurable-tolerance branch from f9aef6d to 4ce48b6 Compare March 25, 2025 18:28
@raywainman
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 869e19553755cf33f93a03e1865185ed76be7168

sftim
sftim reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

If we can tweak the nits I noticed, even better.

@jm-franc @sftim
Apply suggestions from code review
2964572 
Fix nits following code-review.

Co-authored-by: Tim Bannister <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from raywainman March 26, 2025 13:37
@jm-franc
Copy link
Contributor Author

jm-franc commented Mar 26, 2025 •
edited
Loading

LGTM for docs

If we can tweak the nits I noticed, even better.

Thanks @sftim ! I've fixed those nits.

Also please note the associated blog post PR (I see Graziano asks if you could help him lgtm here).

@sftim
Copy link
Contributor

sftim commented Mar 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 74b0ca9d328fca3040b0e7e7933eb80f70e05f2d

@jm-franc
Copy link
Contributor Author

/assign @salaxander

Assigning Xander for approval.

@rayandas
Copy link
Member

rayandas commented Apr 3, 2025

Hello @kerthcet 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation needs an approval. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

kerthcet
kerthcet reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly about scheduling, but
/approve

Thanks!

@kerthcet
Copy link
Member

kerthcet commented Apr 4, 2025

I guess this needs a doc approval?

@rayandas
Copy link
Member

rayandas commented Apr 4, 2025

This PR could use an approval from Docs, @kubernetes/sig-docs-leads thanks!

@jm-franc
Copy link
Contributor Author

jm-franc commented Apr 4, 2025

Friendly ping @salaxander :)

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet, natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit faa24f7 into kubernetes:dev-1.33 Apr 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

@sftim sftim sftim left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@windsonsea windsonsea Awaiting requested review from windsonsea

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@raywainman raywainman Awaiting requested review from raywainman

Assignees

@raywainman raywainman

@salaxander salaxander

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jm-franc @k8s-ci-robot @rayandas @raywainman @sftim @kerthcet @natalisucks @salaxander