Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comms shadows for v1.32 #7288

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Added comms shadows for v1.32 #7288

merged 2 commits into from
Sep 12, 2024

Conversation

mbianchidev
Copy link
Member

Updated groups.yaml to add (and order alphabetically) Comms shadows for the v1.32 cycle

@mbianchidev
Added comms shadows for v1.32
506eead 
Updated groups.yaml to add (and order alphabetically) Comms shadows for the v1.32 cycle
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2024
@saschagrunert
Copy link
Member

/lgtm cancel
CI is not green

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@mbianchidev
Copy link
Member Author

Seems like a trailing whitespace problem (don't mind if the log shows also a bunch of other warnings, I've only edited that one file)

@mbianchidev
Copy link
Member Author

@saschagrunert solved, PTAL :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbianchidev, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8309cd1 into kubernetes:main Sep 12, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 12, 2024
@fsmunoz fsmunoz mentioned this pull request Sep 13, 2024
Merged
@fsmunoz
Copy link
Contributor

fsmunoz commented Sep 13, 2024

xref: kubernetes/sig-release#2603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@mbianchidev @saschagrunert @k8s-ci-robot @fsmunoz