refactor: move app logo to a reusable componentLogo component #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new `KunafaLogo` component for the app logo. - Updated existing files to use the `KunafaLogo` component. - Improved maintainability by centralizing the logo.
mjamal-dev
suggested changes
Jan 29, 2025
.gitignore
Outdated
| @@ -49,6 +49,7 @@ dist/ | |||
| dist/ | |||
| dist-ssr/ | |||
| *.tsbuildinfo | |||
| package-lock.json | |||
There was a problem hiding this comment.
It is a good practice to not ignore package-lock.json for dependency consistency in some projects and this is a good example of one that does. It primarily solves the "It works on my machine" dilemma by making sure all dependencies have the same version across all contributors.
There was a problem hiding this comment.
Thank you for the feedback. I've updated the PR to remove package-lock.json from .gitignore
mjamal-dev
approved these changes
Jan 31, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new KunafaLogo component for the app logo.
Updated existing files to use the KunafaLogo component.
Improved maintainability by centralizing the logo.