Repository navigation
Conversation
…eholder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cubicj
approved these changes
Oct 10, 2026
cubicj
left a comment
Collaborator
There was a problem hiding this comment.
I went through 30b41e6 on this. The note was already saved, shown next to the persona name in the persona list, and carried through PNG export whether or not the option was on. The option only hid the edit field, so removing it opens that field for everyone, and the label no longer shows up without its input. Personas with no saved note, such as ones imported from older PNGs, come up with an empty field and save like any other note once filled in. pnpm check, pnpm test, and pnpm build are clean on this head.
Personally, I think the note is useful enough to be on by default.
Approving — thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Removes the Persona Note option, and localizes its placeholder.
Related Issues
None.
Changes
The Note has been around for a while, yet quite a few users still don't know it exists, and some even said that they had considered developing dedicated plugins for it. It is too minor and stable to be experimental, and too essential to sit behind an option, so this PR removes the option and always enables the persona note.
This PR localizes the Note's placeholder as well.
Changes are split into two commits. If you would rather keep the option, I can drop the second one. Then, this PR will be a bug fix and a localization:
Impact
All users can see the persona note's text input.