Skip to content

feat: Promote Persona Note as default - #1649

Open
enzi221 wants to merge 2 commits into
kwaroran:mainfrom
enzi221:feat/persona-note
Open

enzi221 wants to merge 2 commits into
kwaroran:mainfrom
enzi221:feat/persona-note

Conversation

@enzi221

@enzi221 enzi221 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?
  • If your PR is highly AI generated[^2], check the following:
    • Have you understood what the code does?
    • Have you cleaned up any unnecessary or redundant code?
    • Is it not a huge change?
      • We currently do not accept highly AI generated PRs that are large changes.

Summary

Removes the Persona Note option, and localizes its placeholder.

Related Issues

None.

Changes

The Note has been around for a while, yet quite a few users still don't know it exists, and some even said that they had considered developing dedicated plugins for it. It is too minor and stable to be experimental, and too essential to sit behind an option, so this PR removes the option and always enables the persona note.

This PR localizes the Note's placeholder as well.

Changes are split into two commits. If you would rather keep the option, I can drop the second one. Then, this PR will be a bug fix and a localization:

  • Moves the "Note" label inside the conditional block, so it no longer appears without its input when the option is off. As-is:
    image
  • Localization key for the placeholder.
  • (Still removes experimental status)

Impact

All users can see the persona note's text input.

enzi221 and others added 2 commits October 8, 2026 22:33
…eholder

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubicj cubicj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through 30b41e6 on this. The note was already saved, shown next to the persona name in the persona list, and carried through PNG export whether or not the option was on. The option only hid the edit field, so removing it opens that field for everyone, and the label no longer shows up without its input. Personas with no saved note, such as ones imported from older PNGs, come up with an empty field and save like any other note once filled in. pnpm check, pnpm test, and pnpm build are clean on this head.

Personally, I think the note is useful enough to be on by default.

Approving — thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants