Hotfix/menu contrast issue 341#701
Open
AndrewLopezHerrera wants to merge 2 commits intolabexp:developfrom
Open
Hotfix/menu contrast issue 341#701AndrewLopezHerrera wants to merge 2 commits intolabexp:developfrom
AndrewLopezHerrera wants to merge 2 commits intolabexp:developfrom
Conversation
…een and to the track detail spinner. fix: It resolves the low contrast that existed between the contextual menus and the rest of the application. docs: Nothing
fix: It resolves the low contrast that existed between the contextual menus and the rest of the application. docs: Nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 High-contrast menu borders
🛠️ Issue
📖 Description
Borders have been added to the contextual menus on the main screen and to the track detail spinner. Additionally, a border has been applied to all other popup-style menus. This resolves the low contrast issue that existed between the contextual menus and the rest of the application, especially when menus were layered on top of other lists or UI elements.
🖼️ Screenshots
✅ Pull Request Checklist
📝 Additional Notes
-The contrast ratio between the border color and the background colors is 5.37; a minimum of 4.5 is recommended according to W3C criterion 1.4.3. The contrast ratio was validated using the tool https://app.contrast-finder.org/