Skip to content

Hotfix/menu contrast issue 341 #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewLopezHerrera wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Hotfix/menu contrast issue 341 #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcce9b9
feat: A border has been added to the contextual menus on the main scr…
AndrewLopezHerrera Apr 23, 2026
8092b53
feat: A border has been added to the rest of the popup-style menus.
AndrewLopezHerrera Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/src/main/res/drawable/menu_border_background.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android">
<solid android:color="?android:attr/colorBackground" />
<stroke
android:width="2dp"
android:color="#A4A4A4" /> <corners android:radius="4dp" />
</shape>
1 change: 1 addition & 0 deletions app/src/main/res/layout/trackdetail_fields.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
android:layout_marginTop="8dp"
android:minHeight="48dp"
android:entries="@array/prefs_osm_visibility_keys"
android:popupBackground="@drawable/menu_border_background"
style="@style/Widget.AppCompat.Spinner.Underlined" />

</merge>
3 changes: 3 additions & 0 deletions app/src/main/res/values-v14/theme_highcontrast.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
<!-- item name="android:background">#ffffff</item -->
<item name="android:buttonStyle">@style/Widget.Button</item>
<item name="android:buttonStyleToggle">@style/Widget.Button.Toggle</item>
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
<item name="android:panelBackground">@drawable/menu_border_background</item>
</style>

<style name="Widget.Button" parent="@android:style/Widget.DeviceDefault.Button">
Expand Down
21 changes: 18 additions & 3 deletions app/src/main/res/values-v14/themes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="DefaultTheme" parent="@android:style/Theme.DeviceDefault"/>
<style name="DarkTheme" parent="@android:style/Theme.DeviceDefault"/>
<style name="LightTheme" parent="@android:style/Theme.DeviceDefault.Light"/>
<style name="DefaultTheme" parent="@android:style/Theme.DeviceDefault">
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
<item name="android:panelBackground">@drawable/menu_border_background</item>
</style>
<style name="DarkTheme" parent="@android:style/Theme.DeviceDefault">
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
<item name="android:panelBackground">@drawable/menu_border_background</item>
</style>
<style name="LightTheme" parent="@android:style/Theme.DeviceDefault.Light">
<item name="android:actionOverflowMenuStyle">@style/NativePopupMenu</item>
<item name="android:popupMenuStyle">@style/NativePopupMenu</item>
<item name="android:panelBackground">@drawable/menu_border_background</item>
</style>
<style name="NativePopupMenu" parent="">
<item name="android:popupBackground">@drawable/menu_border_background</item>
</style>
</resources>
9 changes: 8 additions & 1 deletion app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
<item name="colorPrimaryDark">@color/colorPrimaryDark</item>
<item name="colorAccent">@color/colorAccent</item>
-->

<item name="actionOverflowMenuStyle">@style/PopupMenu</item>
<item name="popupMenuStyle">@style/PopupMenu</item>
<item name="android:contextPopupMenuStyle">@style/PopupMenu</item>
</style>

<!-- Base application theme. -->
Expand All @@ -20,4 +22,9 @@
-->
</style>

<style name="PopupMenu" parent="Widget.AppCompat.PopupMenu.Overflow">
<item name="android:popupBackground">@drawable/menu_border_background</item>
</style>


</resources>
Loading