-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1636): Add a control to the reservoir page for entering a HuggingFace token. #4500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 51.38% | 130/253 |
| 🔴 | Branches | 30.3% | 80/264 |
| 🔴 | Functions | 34.48% | 20/58 |
| 🔴 | Lines | 53.85% | 119/221 |
Test suite run success
55 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from 39aa767
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.65% (-0% 🔻) |
531/11429 |
| 🔴 | Branches | 3.77% | 302/8008 |
| 🔴 | Functions | 2.89% (-0% 🔻) |
102/3533 |
| 🔴 | Lines | 4.59% (-0% 🔻) |
513/11172 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 39aa767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Hugging Face registry settings functionality to the Backend.AI WebUI application. The changes enable users to manage their Hugging Face authentication tokens through a dedicated settings modal.
- Introduces a new BAIHuggingFaceRegistrySettingModal component for token management
- Updates internationalization files across all supported languages
- Integrates the settings modal into the ReservoirPage with a settings button
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/backend-ai-webui.ts | Adds 'reservoir' to the list of admin-only pages |
| react/src/pages/ReservoirPage.tsx | Integrates the Hugging Face settings modal with a new settings button and GraphQL query |
| packages/backend.ai-ui/src/components/fragments/BAIHuggingFaceRegistrySettingModal.tsx | New modal component for managing Hugging Face registry tokens |
| packages/backend.ai-ui/src/components/fragments/index.ts | Exports the new BAIHuggingFaceRegistrySettingModal component |
| packages/backend.ai-ui/src/components/fragments/BAIArtifactTable.tsx | Changes table size to "small" and fixes self-closing tag |
| resources/i18n/*.json | Adds "Settings" translation across all language files and removes outdated "FromHuggingFace" key, adds "ImportModel" |
| packages/backend.ai-ui/src/locale/*.json | Adds translations for the new Hugging Face settings modal and button labels |
| .cspell.json | Adds "huggingface" to the spell check dictionary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/backend.ai-ui/src/components/fragments/BAIHuggingFaceRegistrySettingModal.tsx
Show resolved
Hide resolved
packages/backend.ai-ui/src/components/fragments/BAIHuggingFaceRegistrySettingModal.tsx
Show resolved
Hide resolved
fa21d0c to
88b1f73
Compare
packages/backend.ai-ui/src/components/fragments/BAIHuggingFaceRegistrySettingModal.tsx
Show resolved
Hide resolved
9a013ed to
e1c7b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve merge conflicts
e1c7b8e to
39aa767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Resolves #4496 (FR-1636)
Add HuggingFace Registry Settings Modal
This PR adds a new modal component for managing HuggingFace registry settings, allowing users to view, update, and reset their HuggingFace token. The component includes:
BAIHuggingFaceRegistrySettingModalcomponent with token management functionalityThe PR also makes minor UI improvements to the artifact table by setting its size to "small" and renaming the HuggingFace import button to "Import Model" for clarity.
Checklist: