-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1636): Add a control to the reservoir page for entering a HuggingFace token. #4500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agatha197
wants to merge
2
commits into
main
Choose a base branch
from
feat_FR-1636_/reservoir-token-modal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+493
−25
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,7 @@ | |
| "Frgmts", | ||
| "Gaudi", | ||
| "hoverable", | ||
| "huggingface", | ||
| "Hyperaccel", | ||
| "keypair", | ||
| "Keypairs", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
174 changes: 174 additions & 0 deletions
174
packages/backend.ai-ui/src/components/fragments/BAIHuggingFaceRegistrySettingModal.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| import { BAIHuggingFaceRegistrySettingModalFragment$key } from '../../__generated__/BAIHuggingFaceRegistrySettingModalFragment.graphql'; | ||
| import { UpdateHuggingFaceRegistryInput } from '../../__generated__/BAIHuggingFaceRegistrySettingModalMutation.graphql'; | ||
| import { toLocalId } from '../../helper'; | ||
| import { useErrorMessageResolver } from '../../hooks'; | ||
| import BAIFlex from '../BAIFlex'; | ||
| import BAIModal, { BAIModalProps } from '../BAIModal'; | ||
| import BAIUnmountAfterClose from '../BAIUnmountAfterClose'; | ||
| import { EditOutlined } from '@ant-design/icons'; | ||
| import { App, Button, Form, FormInstance, Input } from 'antd'; | ||
| import { useState, useRef } from 'react'; | ||
| import { useTranslation } from 'react-i18next'; | ||
| import { graphql, useFragment, useMutation } from 'react-relay'; | ||
|
|
||
| export type BAIHuggingFaceRegistrySettingModalFragmentKey = | ||
| BAIHuggingFaceRegistrySettingModalFragment$key; | ||
|
|
||
| export interface BAIHuggingFaceRegistrySettingModalProps extends BAIModalProps { | ||
| huggingFaceRegistryFragment?: BAIHuggingFaceRegistrySettingModalFragmentKey; | ||
| } | ||
|
|
||
| const BAIHuggingFaceRegistrySettingModal = ({ | ||
| huggingFaceRegistryFragment, | ||
| ...baiModalProps | ||
| }: BAIHuggingFaceRegistrySettingModalProps) => { | ||
| 'use memo'; | ||
| const { t } = useTranslation(); | ||
| const { message, modal } = App.useApp(); | ||
| const { getErrorMessage } = useErrorMessageResolver(); | ||
|
|
||
| const formRef = useRef<FormInstance>(null); | ||
|
|
||
| const huggingFaceRegistry = useFragment( | ||
| graphql` | ||
| fragment BAIHuggingFaceRegistrySettingModalFragment on HuggingFaceRegistry { | ||
| id | ||
| token | ||
| } | ||
| `, | ||
| huggingFaceRegistryFragment, | ||
| ); | ||
|
|
||
| const [updateHuggingFaceRegistry, isInflightUpdateHuggingFaceRegistry] = | ||
| useMutation(graphql` | ||
| mutation BAIHuggingFaceRegistrySettingModalMutation( | ||
| $input: UpdateHuggingFaceRegistryInput! | ||
| ) { | ||
| updateHuggingfaceRegistry(input: $input) { | ||
| huggingfaceRegistry { | ||
| id | ||
| token | ||
| } | ||
| } | ||
| } | ||
| `); | ||
|
|
||
| const initialToken = huggingFaceRegistry?.token; | ||
| const [isEditing, setIsEditing] = useState(false); | ||
|
|
||
| const hasToken = initialToken && initialToken.length > 0; | ||
|
|
||
| const executeUpdate = (values: UpdateHuggingFaceRegistryInput) => { | ||
| updateHuggingFaceRegistry({ | ||
| variables: { | ||
| input: { | ||
| id: toLocalId(huggingFaceRegistry!.id), | ||
| token: values.token ?? '', | ||
| }, | ||
| }, | ||
| onCompleted: (_res, errors) => { | ||
| if (errors && errors.length > 0) { | ||
| errors.forEach((err) => message.error(getErrorMessage(err))); | ||
| return; | ||
| } | ||
| message.success( | ||
| t('comp:HuggingFaceRegistrySettingModal.TokenUpdatedSuccessfully'), | ||
| ); | ||
| baiModalProps.onOk?.({} as React.MouseEvent<HTMLButtonElement>); | ||
| }, | ||
| onError: (err) => { | ||
| message.error(getErrorMessage(err)); | ||
| }, | ||
| }); | ||
| }; | ||
|
|
||
| const handleOk = () => { | ||
| if (!huggingFaceRegistry?.id) { | ||
| message.error( | ||
| t('comp:HuggingFaceRegistrySettingModal.HuggingFaceRegistryNotFound'), | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| if (hasToken && !isEditing) { | ||
| // If not editing, no need to update | ||
| message.success( | ||
| t('comp:HuggingFaceRegistrySettingModal.NoChangesToSave'), | ||
| ); | ||
| baiModalProps.onOk?.({} as React.MouseEvent<HTMLButtonElement>); | ||
| return; | ||
| } | ||
|
|
||
| formRef.current | ||
| ?.validateFields() | ||
| .then((values) => { | ||
| // Check if current token exists and is empty string, but new token is not empty | ||
agatha197 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (hasToken && !values.token) { | ||
| modal.confirm({ | ||
| title: t('comp:HuggingFaceRegistrySettingModal.ResetTokenConfirm'), | ||
| content: t( | ||
| 'comp:HuggingFaceRegistrySettingModal.ResetTokenConfirmMessage', | ||
| ), | ||
| onOk() { | ||
| executeUpdate(values); | ||
| }, | ||
| onCancel() { | ||
| // Don't proceed with update | ||
| }, | ||
| okButtonProps: { danger: true }, | ||
| okText: t('general.button.Reset'), | ||
| }); | ||
| } else { | ||
| executeUpdate(values); | ||
| } | ||
| }) | ||
| .catch(() => {}); | ||
| }; | ||
|
|
||
| return ( | ||
| <BAIUnmountAfterClose> | ||
| <BAIModal | ||
| destroyOnHidden | ||
| afterClose={() => setIsEditing(false)} | ||
| {...baiModalProps} | ||
| title={t('comp:HuggingFaceRegistrySettingModal.HuggingFaceSettings')} | ||
| centered | ||
| okText={t('general.button.Save')} | ||
| onOk={handleOk} | ||
| okButtonProps={{ | ||
| loading: isInflightUpdateHuggingFaceRegistry, | ||
| }} | ||
| > | ||
| <Form ref={formRef} layout="vertical"> | ||
| <Form.Item | ||
| label={t('comp:HuggingFaceRegistrySettingModal.Token')} | ||
| name="token" | ||
| > | ||
| {hasToken && !isEditing ? ( | ||
| <BAIFlex gap={'xs'}> | ||
| {/* For security, we display a masked token instead of initial value. */} | ||
| <Input type="password" disabled value="••••••••••••••••" /> | ||
| <Button | ||
| icon={<EditOutlined />} | ||
| onClick={() => { | ||
| setIsEditing(true); | ||
| }} | ||
| type="text" | ||
| /> | ||
| </BAIFlex> | ||
| ) : ( | ||
| <Input.Password | ||
| placeholder={t( | ||
| 'comp:HuggingFaceRegistrySettingModal.EnterToken', | ||
| )} | ||
| autoFocus={isEditing} | ||
| /> | ||
| )} | ||
| </Form.Item> | ||
| </Form> | ||
| </BAIModal> | ||
| </BAIUnmountAfterClose> | ||
| ); | ||
| }; | ||
|
|
||
| export default BAIHuggingFaceRegistrySettingModal; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.