feat(BA-2508): Implement artifact import delegation on remote reservoir registry #6221

jopemachine · 2025-10-07T06:14:41Z

Checklist: (if applicable)

Mention to the original issue

📚 Documentation preview 📚: https://sorna--6221.org.readthedocs.build/en/6221/

📚 Documentation preview 📚: https://sorna-ko--6221.org.readthedocs.build/ko/6221/

src/ai/backend/manager/services/artifact_revision/actions/delegate_import_revision_batch.py

+from ai.backend.manager.services.artifact_revision.actions.base import ArtifactRevisionAction
+
+
+# TODO: Make this a batch action.


src/ai/backend/manager/services/artifact_revision/service.py

+            )
+
+            try:
+                # TODO: Improve this


src/ai/backend/manager/services/artifact_revision/service.py

+        self, artifact_type: Optional[ArtifactType], registry_id_or_none: Optional[uuid.UUID]
+    ) -> ArtifactRegistryData:
+        if registry_id_or_none is None:
+            # TODO: Handle `artifact_type` for other types


Copilot

Pull Request Overview

This PR implements artifact import delegation for remote reservoir registries to enable importing artifacts from remote registries through delegation.

Adds delegate_import_revision_batch service method with conditional delegation logic based on node type
Implements REST and GraphQL APIs for delegating artifact imports
Introduces event handling for remote artifact import completion

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/ai/backend/manager/services/artifact_revision/service.py	Core service implementation for delegation logic and artifact registry resolution
src/ai/backend/manager/api/gql/artifact.py	GraphQL mutation implementation for delegate import
src/ai/backend/manager/api/artifact_registry.py	REST API endpoint for delegation import
src/ai/backend/manager/client/artifact_registry/reservoir_client.py	Client method for remote reservoir communication
src/ai/backend/manager/event_dispatcher/handlers/artifact.py	Event handler for remote import completion
src/ai/backend/manager/services/artifact_revision/actions/delegate_import_revision_batch.py	Action definition for batch delegation
tests/manager/services/artifact_revision/conftest.py	Test configuration updates for new dependency
src/ai/backend/manager/repositories/artifact/repository.py	Database method for updating remote status
src/ai/backend/manager/errors/artifact_registry.py	New error classes for delegation failures
src/ai/backend/manager/dto/request.py	Request model for delegation
src/ai/backend/common/events/event_types/artifact/anycast.py	Event type for remote import completion

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-12T05:52:02Z

src/ai/backend/manager/services/artifact_revision/service.py

@@ -1,3 +1,5 @@
+import uuid


There are redundant imports of uuid. Line 1 imports the uuid module, while line 3 imports UUID from uuid. Consider consolidating these imports or removing the redundant one.

Suggested change

import uuid

Copilot · 2025-10-12T05:52:02Z

src/ai/backend/manager/services/artifact_revision/service.py

+                # TODO: Improve this
+                task_ids = []
+                result: list[ArtifactRevisionData] = []
+                for revision_id in action.artifact_revision_ids:
+                    import_result = await self.import_revision(
+                        ImportArtifactRevisionAction(artifact_revision_id=revision_id)
+                    )
+                    task_ids.append(import_result.task_id)
+                    result.append(import_result.result)


Sequential processing of revision imports could be inefficient for large batches. Consider using asyncio.gather() or similar concurrency patterns to process imports in parallel.

Copilot · 2025-10-12T05:52:03Z

src/ai/backend/manager/services/artifact_revision/service.py

+        self, artifact_type: Optional[ArtifactType], registry_id_or_none: Optional[uuid.UUID]
+    ) -> ArtifactRegistryData:
+        if registry_id_or_none is None:
+            # TODO: Handle `artifact_type` for other types


The TODO comment indicates incomplete implementation for handling different artifact types. This should be documented more clearly or tracked in a separate issue.

Suggested change

# TODO: Handle `artifact_type` for other types

# NOTE: Currently, only 'model' artifact type is supported here.

# Support for other artifact types should be implemented in the future.

# See issue #1234 for tracking this limitation.

Copilot · 2025-10-12T05:52:03Z

src/ai/backend/manager/services/artifact_revision/actions/delegate_import_revision_batch.py

+from ai.backend.manager.services.artifact_revision.actions.base import ArtifactRevisionAction
+
+
+# TODO: Make this a batch action.


The TODO comment suggests this isn't actually implemented as a batch action yet, which contradicts the class name 'BatchAction'. This should be clarified or the implementation should be updated.

Suggested change

# TODO: Make this a batch action.

Copilot · 2025-10-12T05:52:03Z

src/ai/backend/manager/api/gql/artifact.py

+            "Mismatch between artifact revisions and task IDs returned"
+        )
+
+    for task_id, artifact_revision in zip(action_result.task_ids, artifact_revisions, strict=True):


[nitpick] Good use of strict=True in zip() to ensure length consistency between task_ids and artifact_revisions.

src/ai/backend/manager/services/artifact_revision/service.py

Co-authored-by: octodog <[email protected]>

…ote reservoir (#6222)

github-actions bot assigned jopemachine Oct 7, 2025

github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component comp:common Related to Common component labels Oct 7, 2025

jopemachine added this to the 25.15 milestone Oct 7, 2025

github-actions bot added the area:docs Documentations label Oct 7, 2025

github-advanced-security bot found potential problems Oct 7, 2025

View reviewed changes

github-actions bot added size:XL 500~ LoC size:L 100~500 LoC and removed size:L 100~500 LoC size:XL 500~ LoC labels Oct 12, 2025

jopemachine modified the milestones: 25.15, 25.16 Oct 12, 2025

jopemachine changed the title ~~feat(BA-2508): Implement artifact import delegation on remote reservoir registry (WIP)~~ feat(BA-2508): Implement artifact import delegation on remote reservoir registry Oct 12, 2025

jopemachine requested a review from HyeockJinKim October 12, 2025 05:51

jopemachine marked this pull request as ready for review October 12, 2025 05:51

Copilot AI review requested due to automatic review settings October 12, 2025 05:51

Copilot AI reviewed Oct 12, 2025

View reviewed changes

jopemachine commented Oct 13, 2025

View reviewed changes

src/ai/backend/manager/services/artifact_revision/service.py Outdated Show resolved Hide resolved

HyeockJinKim approved these changes Oct 13, 2025

View reviewed changes

github-actions bot added size:XL 500~ LoC comp:storage-proxy Related to Storage proxy component and removed size:L 100~500 LoC labels Oct 13, 2025

jopemachine and others added 7 commits October 13, 2025 09:24

draft

567ca72

docs: Add news fragment

e541acb

chore: update api schema dump

32851a4

Co-authored-by: octodog <[email protected]>

WIP

627dc5a

WIP

5bb7ac3

docs: Rename news fragment

a9f2412

misc: Fix import

790059c

jopemachine and others added 10 commits October 13, 2025 09:24

fix: Wrong exception handling

3698d61

misc: Revert wrong change

520eec4

fix: Remove unused event, event_handler

1c63732

fix: Organize errors

3ecd965

fix: Add missing description

b67d5b7

fix: Add missing description

9464cc2

chore: update api schema dump

ee99351

Co-authored-by: octodog <[email protected]>

fix: is_delegation_leaf -> use_delegation

4037111

feat(BA-2507): Implement periodic polling and synchronization for rem…

5c0c76b

…ote reservoir (#6222)

fix: Merge conflct

b43c2d5

jopemachine force-pushed the feat/BA-2508 branch from 1cafe35 to b43c2d5 Compare October 13, 2025 09:33

HyeockJinKim enabled auto-merge October 13, 2025 09:36

HyeockJinKim added this pull request to the merge queue Oct 13, 2025

Merged via the queue into main with commit a26dd15 Oct 13, 2025
30 checks passed

HyeockJinKim deleted the feat/BA-2508 branch October 13, 2025 09:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(BA-2508): Implement artifact import delegation on remote reservoir registry #6221

feat(BA-2508): Implement artifact import delegation on remote reservoir registry #6221

Uh oh!

jopemachine commented Oct 7, 2025 •

edited by github-actions bot

Loading

Uh oh!

Check notice

Check notice

Check notice

Copilot AI left a comment

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

Copilot AI Oct 12, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		from ai.backend.manager.services.artifact_revision.actions.base import ArtifactRevisionAction


		# TODO: Make this a batch action.

-            # TODO: Handle `artifact_type` for other types
+            # NOTE: Currently, only 'model' artifact type is supported here.
+            # Support for other artifact types should be implemented in the future.
+            # See issue #1234 for tracking this limitation.

feat(BA-2508): Implement artifact import delegation on remote reservoir registry #6221

feat(BA-2508): Implement artifact import delegation on remote reservoir registry #6221

Uh oh!

Conversation

jopemachine commented Oct 7, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jopemachine commented Oct 7, 2025 •

edited by github-actions bot

Loading