feat(l2): add prover benchmarks from L1 RPC downloaded blocks #1705

xqft · 2025-01-13T20:46:31Z

Motivation

We want to benchmark our block prover against other solutions, using Ethereum mainnet/testnet blocks. For this we need to fetch state from an Ethereum chain.

Description

adds l2/prover/bench crate
adds state fetching functions from the JSON-RPC API (account, block, storage, proofs)
adds a RpcDB type to download and cache needed state during block execution
adds an execute() function to the Prover type

Some bugs were discovered while testing execution of blocks:

fixes state verification (via state and storage MPTs), verify_db()
fixes withdrawals not being processed when using ExecutionDB
fixes beacon root call state changes not being comitted when using ExecutionDB
fixes serialization errors in SP1 caused by the requests_hash field of a block header

github-actions · 2025-01-13T20:49:21Z

| File                                                                       | Lines | Diff |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex_l2/src/commands/test.rs         | 207   | -3   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/blockchain.rs            | 203   | -9   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/payload.rs               | 546   | -15  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/proposer/prover_server.rs        | 457   | +8   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/cache.rs        | 23    | +23  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/constants.rs    | 39    | +39  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/lib.rs          | 3     | +3   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/main.rs         | 101   | +101 |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/rpc/db.rs       | 413   | +413 |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/rpc/mod.rs      | 319   | +319 |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/src/prover.rs             | 146   | +28  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/zkvm/interface/build.rs   | 29    | +14  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/zkvm/interface/src/lib.rs | 179   | +15  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/utils/prover/proving_systems.rs  | 128   | +5   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/utils/test_data_io.rs            | 88    | +3   |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/backends/revm_b.rs               | 554   | +29  |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/db.rs                            | 363   | +188 |
+----------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/execution_db.rs                  | 175   | -54  |
+----------------------------------------------------------------------------+-------+------+

Total lines added: +1188
Total lines removed: 81
Total lines changed: 1269

This reverts commit 33bfb8d.

fborello-lambda

Ready to merge 🚀

I would add a block cache to test the bench quickly.

This reverts commit 8cd4f42.

fkrause98 · 2025-02-24T14:59:36Z

crates/l2/prover/bench/Makefile

+.PHONY: sp1
+
+# Execution only
+ifdef BLOCK_NUMBER


Where does block number come from?

fkrause98 · 2025-02-24T15:44:07Z

crates/l2/prover/src/prover.rs

        )))
    }

+    fn execute(


Is this working after updating Rust to 1.82?

**Motivation** We want to benchmark our block prover against other solutions, using Ethereum mainnet/testnet blocks. For this we need to fetch state from an Ethereum chain. **Description** - adds `l2/prover/bench` crate - adds state fetching functions from the JSON-RPC API (account, block, storage, proofs) - adds a `RpcDB` type to download and cache needed state during block execution - adds an `execute()` function to the `Prover` type Some bugs were discovered while testing execution of blocks: - fixes state verification (via state and storage MPTs), `verify_db()` - fixes withdrawals not being processed when using `ExecutionDB` - fixes beacon root call state changes not being comitted when using `ExecutionDB` - fixes serialization errors in SP1 caused by the `requests_hash` field of a block header --------- Co-authored-by: Mario Rugiero <[email protected]> Co-authored-by: fborello-lambda <[email protected]> Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: ilitteri <[email protected]>

…based approach (lambdaclass#1709) **Motivation** A `ExecutionDB` is created from a block's pre-execution but the current implementation is incorrect and not all needed data gets stored. The goal is to replace this with another approach, using an auxiliary "caching" database that will retrieve data from a `Store` or an RPC endpoint (like in lambdaclass#1705) during the pre-execution of a block, finally resulting in a db that contains all the needed execution data. **Description** - replace `ExecutionDB::from_exec()` to use the `CacheDB`, rename it to `from_store()` - some refactors

…class#1705) **Motivation** We want to benchmark our block prover against other solutions, using Ethereum mainnet/testnet blocks. For this we need to fetch state from an Ethereum chain. **Description** - adds `l2/prover/bench` crate - adds state fetching functions from the JSON-RPC API (account, block, storage, proofs) - adds a `RpcDB` type to download and cache needed state during block execution - adds an `execute()` function to the `Prover` type Some bugs were discovered while testing execution of blocks: - fixes state verification (via state and storage MPTs), `verify_db()` - fixes withdrawals not being processed when using `ExecutionDB` - fixes beacon root call state changes not being comitted when using `ExecutionDB` - fixes serialization errors in SP1 caused by the `requests_hash` field of a block header --------- Co-authored-by: Mario Rugiero <[email protected]> Co-authored-by: fborello-lambda <[email protected]> Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: ilitteri <[email protected]>

xqft added 2 commits January 14, 2025 12:31

add indexdb

94fb3e3

rename InnerIndexDB to AuxIndexDB

2847cf8

xqft mentioned this pull request Jan 14, 2025

fix(l2): replace ExecutionDB from_exec() impl to use a CacheDB based approach #1709

Merged

xqft added 4 commits January 15, 2025 11:06

add IndexDBError

89ba179

change Revm EVM error to ours

f5192c4

replace from_exec impl with indexdb

9616b7d

Merge branch 'main' into l2/touched_state

9d97192

xqft force-pushed the l2/rpc_bench branch from eb514ad to 98bab67 Compare January 15, 2025 20:46

xqft changed the base branch from main to l2/touched_state January 15, 2025 20:46

xqft added 17 commits January 17, 2025 11:39

WIP add PreExecDB

253ab7f

WIP add proofs in from_store()

966706e

WIP remove internal mutability

2135a08

refactor

eabd6a3

replace PreExecDB with CacheDB

9ffbc44

nits

a308649

fix filter

b0d214f

add nonce and balance validations during pre-exec

1b64809

put proofs inside executiondb

dd75353

fix errors

389ddab

remove optiona_balance_check feature

fec82ef

remove unused errors

0405835

fix filter

987e359

add db verification

4a0a715

remove unused imports

eb98e53

update sp1 prover

892060a

Merge branch 'main' into l2/touched_state

d9aee43

xqft force-pushed the l2/rpc_bench branch from 98bab67 to c756be3 Compare January 20, 2025 20:56

xqft mentioned this pull request Jan 21, 2025

perf(l2): rpc comparison bench #1360

Closed

remove revm types

6f2169c

xqft added 5 commits February 21, 2025 13:48

Delete crates/l2/prover/zkvm/interface/sp1/.gitignore

d6cf9c3

replace cache by program input

33bfb8d

Revert "replace cache by program input"

087b1eb

This reverts commit 33bfb8d.

Merge branch 'l2/fix_prover_requests_hash' into l2/rpc_bench

6877a61

serialize parent block header as json

a8b3447

fborello-lambda approved these changes Feb 21, 2025

View reviewed changes

jrchatruc approved these changes Feb 21, 2025

View reviewed changes

jrchatruc and others added 6 commits February 21, 2025 19:23

Test

8cd4f42

Add L1 genesis for dev node (with Pectra disabled)

29d0ca9

Temporary disable Pectra in the L2

0df02fb

Load dev L1 genesis

5de4d37

Revert "Test"

aacfd2f

This reverts commit 8cd4f42.

Merge branch 'temporary_fix' into l2/rpc_bench

a3e701e

jrchatruc enabled auto-merge February 24, 2025 14:09

fkrause98 reviewed Feb 24, 2025

View reviewed changes

crates/l2/prover/bench/Makefile

.PHONY: sp1

# Execution only

ifdef BLOCK_NUMBER

Copy link

Contributor

fkrause98 Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does block number come from?

fkrause98 reviewed Feb 24, 2025

View reviewed changes

crates/l2/prover/src/prover.rs

)))

}

fn execute(

Copy link

Contributor

fkrause98 Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this working after updating Rust to 1.82?

fkrause98 approved these changes Feb 24, 2025

View reviewed changes

ilitteri mentioned this pull request Feb 24, 2025

refactor(l1): transform crate blockchain into struct #2047

Merged

jrchatruc and others added 2 commits February 24, 2025 16:37

Fix loadtest rlp file

a6cdb2f

fix perf_zkvm block to prove index

64d81a0

jrchatruc added this pull request to the merge queue Feb 24, 2025

Merged via the queue into main with commit 1084c97 Feb 24, 2025
24 checks passed

jrchatruc deleted the l2/rpc_bench branch February 24, 2025 20:37

jrchatruc mentioned this pull request Feb 24, 2025

fix(l1, l2): temporary fix to L1 dev and L2 block producer #2055

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(l2): add prover benchmarks from L1 RPC downloaded blocks #1705

feat(l2): add prover benchmarks from L1 RPC downloaded blocks #1705

Uh oh!

xqft commented Jan 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 13, 2025 •

edited

Loading

Uh oh!

fborello-lambda left a comment

Uh oh!

fkrause98 Feb 24, 2025

Uh oh!

fkrause98 Feb 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat(l2): add prover benchmarks from L1 RPC downloaded blocks #1705

feat(l2): add prover benchmarks from L1 RPC downloaded blocks #1705

Uh oh!

Conversation

xqft commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fborello-lambda left a comment

Choose a reason for hiding this comment

Uh oh!

fkrause98 Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

fkrause98 Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xqft commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading