Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(l1, l2, levm): replace levm feature flag with vm CLI flag #1706

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ilitteri
Copy link
Contributor

Motivation

Description

Closes #issue_number

Copy link

github-actions bot commented Jan 13, 2025

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.250 ± 0.010 7.237 7.265 1.00
levm_factorial 26.839 ± 0.239 26.546 27.229 3.70 ± 0.03

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 7.774 ± 1.537 6.783 10.081 1.00
levm_fibonacci 24.817 ± 0.238 24.643 25.355 3.19 ± 0.63

Main Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.316 ± 0.009 7.299 7.326 1.00
levm_factorial 26.625 ± 0.624 26.243 28.337 3.64 ± 0.09

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 6.995 ± 0.030 6.923 7.029 1.00
levm_fibonacci 25.149 ± 1.410 24.286 28.835 3.60 ± 0.20

Copy link

github-actions bot commented Jan 14, 2025

| File                                                                                       | Lines | Diff |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/ethrex/test_runner.rs                         | 139   | +2   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/levm/runner/revm_runner.rs                    | 465   | +4   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex/cli.rs                                          | 141   | +9   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex/ethrex.rs                                       | 345   | +6   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex_l2/src/commands/prove.rs                        | 48    | +5   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/blockchain.rs                            | 196   | +13  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/fork_choice.rs                           | 197   | +9   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/smoke_test.rs                            | 208   | +27  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/utils/prover/save_state.rs                       | 439   | +3   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/utils/test_data_io.rs                            | 85    | -1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/peer_channels.rs                     | 388   | +20  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/sync.rs                              | 614   | +13  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/engine/exchange_transition_config.rs | 64    | +1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/engine/fork_choice.rs                | 264   | -1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/engine/payload.rs                    | 324   | -1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/account.rs                       | 227   | +5   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/block.rs                         | 359   | +1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/client.rs                        | 28    | +1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/filter.rs                        | 557   | +12  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/gas_price.rs                     | 125   | +1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/mod.rs                           | 166   | +4   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/transaction.rs                   | 580   | +38  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/rpc.rs                               | 444   | +10  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/utils.rs                             | 259   | +4   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/db.rs                                            | 6     | -84  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/errors.rs                                        | 103   | -12  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/execution_db.rs                                  | 180   | -4   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm.rs                                          | 213   | +213 |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/call_frame.rs                           | 129   | +5   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/precompiles.rs                          | 943   | -12  |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/vm.rs                                   | 1029  | -1   |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/revm.rs                                          | 637   | +637 |
+--------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/vm.rs                                            | 75    | -691 |
+--------------------------------------------------------------------------------------------+-------+------+

Total lines added: +1043
Total lines removed: 807
Total lines changed: 1850

@ilitteri ilitteri self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant