feat(l1): implement EIPs 7685 and 6110 #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…nto feat/eips-7685-6110
| @@ -129,6 +130,7 @@ async fn transfer_from( | |||
| retries += 1; | |||
| sleep(std::time::Duration::from_secs(2)); | |||
| } | |||
| sleep(Duration::from_millis(3)); | |||
There was a problem hiding this comment.
This is used to generate the l2-loadtest.rlp. It was generating to many transactions in one block and making it tedious to regenerate the file.
There was a problem hiding this comment.
It should be easier to regenerate the file in the future if needed.
test_data/l2-loadtest.rlp
Outdated
There was a problem hiding this comment.
I've regenerated this file to work with the validate_prague_block_header function
JulianVentura
approved these changes
Feb 14, 2025
crates/common/types/requests.rs
Outdated
| pub fn to_bytes(&self) -> Vec<u8> { | ||
| match self { | ||
| Requests::Deposit(deposits) => { | ||
| let mut deposit_data = vec![]; |
There was a problem hiding this comment.
Suggested change
| let mut deposit_data = vec![]; | |
| let deposit_data = deposits.iter().flat_map(|d| d.to_summarized_byte_array()); | |
| std::iter::once(DEPOSIT_TYPE).chain(deposit_data).collect() |
mpaulucci
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to support the Prague update.
Description
This PR implements EIP-7685 and EIP-6110.
Observation
Two ef_tests from
vectors/prague/eip6110_depositswhere excluded since we need the latest version of the evm to pass them.Closes #1787
Closes #1789