chore(l1): standarize revm/levm behaviour when importing blocks. #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
commented
Apr 11, 2025
|
|
||
| if let Some(last_block) = blocks.last() { | ||
| let hash = last_block.hash(); | ||
| if let Err(error) = apply_fork_choice(&store, hash, hash, hash).await { |
There was a problem hiding this comment.
applying forkchoice should set all the blocks as canonical, you don't need to do it explicitly
fmoletta
reviewed
Apr 11, 2025
| @@ -306,5 +307,32 @@ pub async fn import_blocks(path: &str, data_dir: &str, network: &str, evm: EvmEn | |||
| info!("Importing blocks from chain file: {path}"); | |||
| utils::read_chain_file(path) | |||
| }; | |||
| blockchain.import_blocks(&blocks).await; | |||
There was a problem hiding this comment.
Why remove the method instead of refactoring it?
There was a problem hiding this comment.
I don't see the point of having such a function. It is ambiguous with add_block(s). What is the point of having a function that adds blocks + calls forkchoice instead of calling the two function separately?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description