Skip to content

fix: Ensure PlatformScheduleAction order is preserved #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Ensure PlatformScheduleAction order is preserved #176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0c0cc
fix: Ensure PlatformScheduleAction order is preserved
jsonbailey Oct 21, 2025
bb49069
try linking actions to avoid wait
jsonbailey Oct 23, 2025
e0169d4
use the default and run the continuation task async
jsonbailey Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkgs/sdk/client/src/PlatformSpecific/AsyncScheduler.netstandard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,15 @@ internal static partial class AsyncScheduler
{
private static void PlatformScheduleAction(Action a)
{
Task.Run(a);
try
{
// Wait for the task to complete to ensure that actions are executed in the correct order.
Task.Run(a).Wait();
Copy link
Member

@kinyoklion kinyoklion Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a timeout here? Or do we already not timeout, and require the application code return in a timely manner?

Copy link
Contributor

@tanderson-ld tanderson-ld Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think any amount of wait violates the AsyncScheduler contract, no?

Copy link
Member

@kinyoklion kinyoklion Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this probably isn't good on the caller side of the equation. It still does feel like we need a thread specifically to wait for these tasks, or a pool of 1 that we just submit to.

Copy link
Contributor

@tanderson-ld tanderson-ld Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a queue of tasks that get linked together as added and the next is dispatched as the previous finishes?

Copy link
Member

@kinyoklion kinyoklion Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that works as well, potentially very similar to the async queues we've implemented for the CSI spec.

Copy link
Contributor Author

@jsonbailey jsonbailey Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it to be a chained list of calls. The continueWith should still work even if an action throws an exception. This should allow us to keep the same contract but enforce the order.

}
catch (Exception)
{
// Swallow exceptions to prevent them from propagating to the caller.
}
Copy link

@cursor cursor bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Silent Exception Handling Hides Critical Errors

The catch block in PlatformScheduleAction silently swallows all exceptions from scheduled actions without logging or notifying the caller. This hides potential bugs and critical errors, making debugging difficult and possibly leading to unexpected application behavior.

Fix in Cursor Fix in Web

Copy link
Member

@kinyoklion kinyoklion Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we log something here?

Copy link
Contributor Author

@jsonbailey jsonbailey Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should behave similar to the existing code where we fire off a task and are not returning any values. Because we are now Waiting, there is a chance for exceptions to surface and bubble up to the caller which breaks the existing functionality.

}
}
}
Loading