refactor: remove obsolete core ty overrides - #176
Merged
Conversation
lbliii
force-pushed
the
codex/narrow-ty-overrides
branch
from
July 6, 2026 20:35
a7ab9c8 to
085188a
Compare
lbliii
marked this pull request as ready for review
July 7, 2026 14:33
There was a problem hiding this comment.
Pull request overview
This PR removes previously broad ty override blocks that downgraded unresolved-attribute to warnings for core compiler/parser/analysis modules, restoring normal ty error severity while keeping narrowly scoped, explicitly justified overrides (safe-string wrappers and optional imports).
Changes:
- Removed the three obsolete
unresolved-attribute = "warn"override blocks covering core compiler, parser, and analysis modules. - Preserved existing targeted overrides for safe-string wrapper LSP exceptions and optional imports used by contrib/terminal tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unresolved-attribute = "warn"overridestyerror severity across Kida's core parsing, codegen, and static-analysis pipelinesAdvances #142. Draft PR #163 supplies the non-overlapping RFC/history update required by that issue.
Verification
make tymake lintmake test(4280 passed, 5 skipped)uv run pytest tests/analysis tests/unit/test_a11y.py tests/unit/test_purity.py tests/unit/test_type_checker.py(289 passed)uv run pytest tests/test_kida_parser_edge_cases.py tests/test_kida_property_parser.py tests/test_compiler_expr_dispatch.py tests/test_kida_compiler_edge_cases.py(135 passed, 1 skipped)git diff --checkSteward Notes
tyseveritymake ty, full test suite, affected analysis tests, and parser/compiler regression suites