Skip to content

refactor: remove obsolete core ty overrides - #176

Merged
lbliii merged 1 commit into
mainfrom
codex/narrow-ty-overrides
Jul 7, 2026
Merged

refactor: remove obsolete core ty overrides#176
lbliii merged 1 commit into
mainfrom
codex/narrow-ty-overrides

Conversation

@lbliii

@lbliii lbliii commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove all three obsolete parser, compiler, and analysis unresolved-attribute = "warn" overrides
  • restore normal ty error severity across Kida's core parsing, codegen, and static-analysis pipelines
  • preserve only unrelated, explicitly justified overrides for safe-string wrappers and optional imports

Advances #142. Draft PR #163 supplies the non-overlapping RFC/history update required by that issue.

Verification

  • make ty
  • make lint
  • make test (4280 passed, 5 skipped)
  • uv run pytest tests/analysis tests/unit/test_a11y.py tests/unit/test_purity.py tests/unit/test_type_checker.py (289 passed)
  • uv run pytest tests/test_kida_parser_edge_cases.py tests/test_kida_property_parser.py tests/test_compiler_expr_dispatch.py tests/test_kida_compiler_edge_cases.py (135 passed, 1 skipped)
  • git diff --check

Steward Notes

  • Consulted: static-analysis, parser/syntax, compiler/codegen, and planning stewards
  • Accepted: remove each override only after independently proving its included modules pass at normal ty severity
  • Required proof: full make ty, full test suite, affected analysis tests, and parser/compiler regression suites
  • No collateral: runtime behavior, public APIs, syntax, diagnostics, docs, examples, schemas, and benchmarks are unaffected because this only strengthens existing static-check configuration
  • Planning collateral: handled in draft PR [codex] clarify active and historical plans #163 to avoid conflicting edits to the same historical RFCs

@lbliii
lbliii force-pushed the codex/narrow-ty-overrides branch from a7ab9c8 to 085188a Compare July 6, 2026 20:35
@lbliii lbliii changed the title refactor: remove obsolete analysis ty override refactor: remove obsolete core ty overrides Jul 6, 2026
@lbliii
lbliii marked this pull request as ready for review July 7, 2026 14:33
Copilot AI review requested due to automatic review settings July 7, 2026 14:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes previously broad ty override blocks that downgraded unresolved-attribute to warnings for core compiler/parser/analysis modules, restoring normal ty error severity while keeping narrowly scoped, explicitly justified overrides (safe-string wrappers and optional imports).

Changes:

  • Removed the three obsolete unresolved-attribute = "warn" override blocks covering core compiler, parser, and analysis modules.
  • Preserved existing targeted overrides for safe-string wrapper LSP exceptions and optional imports used by contrib/terminal tooling.

@lbliii
lbliii merged commit 8359e6c into main Jul 7, 2026
11 checks passed
@lbliii
lbliii deleted the codex/narrow-ty-overrides branch July 7, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants