Conversation
show how to explicitly set Pico environment variables, use lolcat to colorize notable Pico settings in shell output, added shell message to tell how to exit the shell made by nix develop
|
@gundralaa @lhstrh @edwardalee @hokeun kindly request review |
|
@khasc Thanks for suggesting changes. I'm not very familiar with this repo, although I use the fork of this (https://github.com/lf-lang/lf-3pi-template) for teaching. I would like to keep this template as simple as possible. Could you elaborate on why this change is necessary? |
edwardalee
left a comment
edwardalee
left a comment
There was a problem hiding this comment.
These look like nice changes to me. I like the colorization of the output.
No need to set PICO_PLATFORM because it is optional (it can be auto-set from within the header file specified by PICO_BOARD.) Include reference to and quotes from Pico-series C/C++ SDK
explicitly set PICO_PLATFORM to empty value, which allows board header to set it automatically. this is presumably better than leaving it to whatever was last set in the environment
How to use LF with the newer RP2350-based boards like Pico 2 and Pico 2 W. Environment variables can be set in shell.nix. Note that PICO_PLATFORM is auto-set in board headers.
To find board header files for RP2350-based boards, `git switch master -f`. Without this, the Pico SDK is too early to know about them. With it, there are 60 boards referencing the RP2350.
combine "Support for RP2350-based boards" into the "Setup" section, before `nix develop`
remove # git switch master -f # needed for newer Pico 2 boards TODO: bump up pico-sdk
* reduce information details * add link to SDK book * used alert/callout to avoid making another section just for nix develop
* restored lede by containing RP2350 to the Note in Setup
Thanks @hokeun for the feedback. It's not crucial to change this repo right away, but it might let people use LF with over 120 Pico-series boards rather quickly. Basically it requires specifying the board header file name (without extension) to Pico-SDK -- see PR. Not sure if LF already tries to do the same thing by |
3 participants
show how to explicitly set Pico environment variables, use lolcat to colorize notable Pico settings in shell output, added shell message to tell how to exit the shell made by nix develop