Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: deduplicate common code into sshutil #3129

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Refactor: deduplicate common code into sshutil #3129

merged 1 commit into from
Jan 21, 2025

Conversation

afbjorklund
Copy link
Member

@afbjorklund afbjorklund commented Jan 19, 2025 •
edited
Loading

Addresses:

// FIXME: deduplicate the code clone across `limactl shell` and `limactl tunnel`

@afbjorklund afbjorklund mentioned this pull request Jan 19, 2025
Merged
AkihiroSuda
AkihiroSuda previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v1.0.4 milestone Jan 20, 2025
AkihiroSuda
AkihiroSuda reviewed Jan 20, 2025
View reviewed changes
pkg/sshutil/sshutil.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 3a59746 into lima-vm:master Jan 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@afbjorklund @AkihiroSuda