Improve thread-safety and reconnection reliability for hasPublished flag #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2184b0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidliu
approved these changes
Nov 24, 2025
Merged
adrian-niculescu
deleted the
fix/publisher-hasPublished-thread-safety
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidliu, this PR cherry-picks the independent fixes from #797 that remain valuable after #813 was merged.
Changes:
@VolatiletohasPublishedfor proper memory visibility across threadshasPublished = truebefore the connection check so reconnect() can re-trigger negotiation even if the first attempt occurs before Signal connectsThese changes improve thread-safety and fix a reconnection edge case where the publisher intent could be lost if negotiation was triggered before the signal client connected.