Skip to content

Improve thread-safety and reconnection reliability for hasPublished flag #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 1 commit into from
Nov 24, 2025
Merged

Improve thread-safety and reconnection reliability for hasPublished flag #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-hasPublished-thread-safety.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Improve thread-safety and reconnection reliability for hasPublished flag.
7 changes: 5 additions & 2 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/RTCEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ internal constructor(
@Volatile
private var isClosed = true

@Volatile
private var hasPublished = false

private var coroutineScope = CloseableCoroutineScope(SupervisorJob() + ioDispatcher)
Expand Down Expand Up @@ -676,12 +677,14 @@ internal constructor(
}

internal fun negotiatePublisher() {
// Mark intent to publish before checking Signal state so reconnect() can
// re-trigger negotiation even if the first attempt occurs before Signal connects.
hasPublished = true

if (!client.isConnected) {
return
}

hasPublished = true

coroutineScope.launch {
if (negotiatePublisherMutex.tryLock()) {
try {
Expand Down