Properly reset network callback manager after disconnect #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 47bc518 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrian-niculescu
approved these changes
Dec 23, 2025
| return@runBlocking | ||
| } | ||
| networkCallbackManager.unregisterCallback() | ||
| hasLostConnectivity = false |
Contributor
There was a problem hiding this comment.
Good catch! I had this on my list to look at.
Minor concern: consider adding @Volatile in the declaration to make it:
@Volatile
private var hasLostConnectivity: Boolean = falseNetwork callbacks run on the system's ConnectivityManager thread, while room operations run on coroutine dispatchers. While the current code is functionally safe (unregister happens before reset, so no concurrent access), adding @Volatile would be a good defensive move, imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.