Skip to content

Properly reset network callback manager after disconnect #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidliu wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Properly reset network callback manager after disconnect #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/five-games-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Properly reset network callback manager after disconnect
1 change: 1 addition & 0 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/Room.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,6 +969,7 @@ constructor(
return@runBlocking
}
networkCallbackManager.unregisterCallback()
hasLostConnectivity = false
Copy link
Contributor

@adrian-niculescu adrian-niculescu Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I had this on my list to look at.
Minor concern: consider adding @Volatile in the declaration to make it:

@Volatile
private var hasLostConnectivity: Boolean = false

Network callbacks run on the system's ConnectivityManager thread, while room operations run on coroutine dispatchers. While the current code is functionally safe (unregister happens before reset, so no concurrent access), adding @Volatile would be a good defensive move, imo.


state = State.DISCONNECTED
cleanupRoom()
Expand Down