Update module github.com/pion/rtp to v2 - #603
Conversation
af8dcab to
ea4c92d
Compare
ea4c92d to
d5c58fc
Compare
d5c58fc to
d3810f8
Compare
19e1778 to
2b93c6c
Compare
892f4d5 to
98be49e
Compare
98be49e to
396ccd2
Compare
396ccd2 to
5a23ecd
Compare
5a23ecd to
c691faf
Compare
c691faf to
aaff524
Compare
aaff524 to
1c628d6
Compare
1c628d6 to
f634979
Compare
a756e2e to
bcb58df
Compare
5be8bf2 to
5dcdf73
Compare
5dcdf73 to
b8ecc83
Compare
b8ecc83 to
8ef3b4c
Compare
8ef3b4c to
fc6a614
Compare
357bb7f to
5fbd841
Compare
5fbd841 to
9d94256
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
9d94256 to
5795ae4
Compare
5795ae4 to
5538acb
Compare
5538acb to
e12eee3
Compare
e12eee3 to
59ff20f
Compare
59ff20f to
3a12d6e
Compare
3a12d6e to
0062eee
Compare
73f101b to
46c4299
Compare
250adc0 to
06219e1
Compare
06219e1 to
1d396dd
Compare
d82c2f9 to
1d396dd
Compare
| github.com/pion/interceptor v0.1.45 | ||
| github.com/pion/rtcp v1.2.16 | ||
| github.com/pion/rtp v1.10.2 | ||
| github.com/pion/rtp/v2 v2.0.0 |
There was a problem hiding this comment.
🟡 Dependency upgrade left the project depending on two copies of the same library
A second copy of the RTP library is listed as a required direct dependency (github.com/pion/rtp/v2 v2.0.0 at go.mod:21) while every source file still uses the old copy, so the upgrade is incomplete and the extra entry is unused.
Impact: The project now declares an unused dependency alongside the old one; dependency-tidiness checks fail and the intended upgrade did not actually happen.
Unused v2 module requirement and incomplete go.sum entry
All Go sources still import github.com/pion/rtp (v1): localtrack.go:29, pkg/synchronizer/track.go:25, pkg/interceptor/pacerinteceptor.go:7, pkg/interceptor/limitsizeinteceptor.go:7, pkg/samplebuilder/samplebuilder.go:26, e2ee/trackdecryptor.go:22, plus tests and examples. Nothing imports github.com/pion/rtp/v2, so go mod tidy would drop the new require line (and any tidy-check in CI would flag the diff).
Additionally go.sum only contains the /go.mod hash for the new module (go.sum:236) and no h1: module-zip hash, so as soon as any code does import v2 the build fails with a missing go.sum entry. Note that pion also depends on v1 transitively via pion/webrtc/v4 and pion/interceptor, so a real migration requires updating those too.
Was this helpful? React with 👍 or 👎 to provide feedback.
Generated by renovateBot
This PR contains the following updates:
v1.10.5→v2.0.0Release Notes
pion/rtp (github.com/pion/rtp)
v2.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.