-
Notifications
You must be signed in to change notification settings - Fork 167
Update module github.com/pion/rtp to v2 #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/major-pion-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Dependency upgrade left the project depending on two copies of the same library
A second copy of the RTP library is listed as a required direct dependency (
github.com/pion/rtp/v2 v2.0.0atgo.mod:21) while every source file still uses the old copy, so the upgrade is incomplete and the extra entry is unused.Impact: The project now declares an unused dependency alongside the old one; dependency-tidiness checks fail and the intended upgrade did not actually happen.
Unused v2 module requirement and incomplete go.sum entry
All Go sources still import
github.com/pion/rtp(v1):localtrack.go:29,pkg/synchronizer/track.go:25,pkg/interceptor/pacerinteceptor.go:7,pkg/interceptor/limitsizeinteceptor.go:7,pkg/samplebuilder/samplebuilder.go:26,e2ee/trackdecryptor.go:22, plus tests and examples. Nothing importsgithub.com/pion/rtp/v2, sogo mod tidywould drop the new require line (and any tidy-check in CI would flag the diff).Additionally
go.sumonly contains the/go.modhash for the new module (go.sum:236) and noh1:module-zip hash, so as soon as any code does import v2 the build fails with a missing go.sum entry. Note that pion also depends on v1 transitively viapion/webrtc/v4andpion/interceptor, so a real migration requires updating those too.Was this helpful? React with 👍 or 👎 to provide feedback.