-
Notifications
You must be signed in to change notification settings - Fork 6
Feat/batch nodes #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/batch nodes #442
Conversation
|
Can you also add an engine build command to You can ignore (or even remove) the multi-resolution builds as they are not used anymore (only slows down the script) comfystream/docker/entrypoint.sh Lines 96 to 101 in f13bd81
|
82528f7 to
5865571
Compare
Dynamically resize queues based on LoadTensor batch_size to optimize memory.
|
@eliteprox which changes request is this i cant see it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lukiod I apologize for the delay getting back to you. I've tested the latest changes and still had issues with flickering frames. We recently had to fix some linting issues in the main branch, so please rebase and I will take a look.
Again, I apologize for the delay, this has been a lower priority feature since we have been working to ship BYOC pipelines and there were some overlapping changes in this PR.
Thank you again for this contribution, I've added the PR to our current planning cycle to maintain more visibility on this feature, as it is important to our roadmap. If it remains stale, we will pick up the feature in a coming sprint
No description provided.