[SV] Remove extract-test-code #8846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
commented
Aug 12, 2025
| static void populateCIRCTSynthPipeline(PassManager &pm) { | ||
| // ExtractTestCode is used to move verification code from design to | ||
| // remove registers/logic used only for verification. | ||
| pm.addPass(sv::createSVExtractTestCodePass( |
There was a problem hiding this comment.
@uenoku please take a look and let me know if you are still relying on ETC :)
There was a problem hiding this comment.
I'm fine as long as they are removed from designs so it's all OK! Thank you for checking!
seldridge
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Can the PR also delete the annotations in AnnotationDetails.h and their handling in the LowerAnnotations pass?
dtzSiFive
approved these changes
Aug 13, 2025
uenoku
approved these changes
Aug 15, 2025
mikeurbach
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extract test code feature from firtool, which has been deprecated in favour of using bound layers.