[Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes #121419

a-tarasyuk · 2024-12-31T23:48:21Z

Fixes #55474

llvmbot · 2024-12-31T23:48:55Z

@llvm/pr-subscribers-libcxx

@llvm/pr-subscribers-clang

Author: Oleksandr T. (a-tarasyuk)

Changes

Fixes #55474

Full diff: https://github.com/llvm/llvm-project/pull/121419.diff

8 Files Affected:

(modified) clang/docs/ReleaseNotes.rst (+1)
(modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+4)
(modified) clang/lib/Sema/SemaDeclCXX.cpp (+9)
(modified) clang/test/CXX/drs/cwg4xx.cpp (+2-1)
(modified) clang/test/CXX/special/class.inhctor/elsewhere.cpp (+3-2)
(modified) clang/test/Sema/GH70594.cpp (+7-6)
(modified) clang/test/SemaCXX/class-base-member-init.cpp (+2-1)
(added) clang/test/SemaCXX/warn-base-type-qualifiers.cpp (+11)

diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index b7da12bcf65818..659f0ebd97fc46 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -733,6 +733,7 @@ Improvements to Clang's diagnostics
       scope.Unlock();
       require(scope); // Warning!  Requires mu1.
     }
+- Clang now emits a ``-Wignored-qualifiers`` diagnostic when a base class includes cv-qualifiers (#GH55474).
 
 Improvements to Clang's time-trace
 ----------------------------------
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td
index 330ae045616aba..ce8e9fc99dcbff 100644
--- a/clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -487,6 +487,10 @@ def err_noreturn_non_function : Error<
 def warn_qual_return_type : Warning<
   "'%0' type qualifier%s1 on return type %plural{1:has|:have}1 no effect">,
   InGroup<IgnoredQualifiers>, DefaultIgnore;
+def warn_qual_base_type : Warning<
+  "'%0' qualifier%s1 on base class type %2 have no effect">,
+  InGroup<IgnoredQualifiers>;
+
 def warn_deprecated_redundant_constexpr_static_def : Warning<
   "out-of-line definition of constexpr static data member is redundant "
   "in C++17 and is deprecated">,
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index c5a72cf812ebc9..df0a15fc44e3e3 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -2655,6 +2655,15 @@ CXXBaseSpecifier *Sema::CheckBaseSpecifier(CXXRecordDecl *Class,
       return nullptr;
     }
 
+    if (BaseType.hasQualifiers()) {
+      auto Quals =
+          BaseType.getQualifiers().getAsString(Context.getPrintingPolicy());
+      Diag(BaseLoc, diag::warn_qual_base_type)
+          << Quals << std::count(Quals.begin(), Quals.end(), ' ') + 1
+          << BaseType;
+      Diag(BaseLoc, diag::note_base_class_specified_here) << BaseType;
+    }
+
     // For the MS ABI, propagate DLL attributes to base class templates.
     if (Context.getTargetInfo().getCXXABI().isMicrosoft() ||
         Context.getTargetInfo().getTriple().isPS()) {
diff --git a/clang/test/CXX/drs/cwg4xx.cpp b/clang/test/CXX/drs/cwg4xx.cpp
index 825065840f1181..0c3ed2f4ebf534 100644
--- a/clang/test/CXX/drs/cwg4xx.cpp
+++ b/clang/test/CXX/drs/cwg4xx.cpp
@@ -1309,7 +1309,8 @@ namespace cwg484 { // cwg484: yes
   }
   CA::A() {}
 
-  struct B : CA {
+  struct B : CA { // expected-warning {{'const' qualifier on base class type 'CA' (aka 'const cwg484::A') have no effect}} \
+                  // expected-note {{base class 'CA' (aka 'const cwg484::A') specified here}}
     B() : CA() {}
     void f() { return CA::f(); }
   };
diff --git a/clang/test/CXX/special/class.inhctor/elsewhere.cpp b/clang/test/CXX/special/class.inhctor/elsewhere.cpp
index f86f4b86faa7d7..079422fd99d98a 100644
--- a/clang/test/CXX/special/class.inhctor/elsewhere.cpp
+++ b/clang/test/CXX/special/class.inhctor/elsewhere.cpp
@@ -57,9 +57,10 @@ template<typename T> struct F : D<bool> {
 F<bool> fb; // expected-note {{here}}
 
 template<typename T>
-struct G : T {
+struct G : T {        // expected-warning {{'const' qualifier on base class type 'const B1' have no effect}} \
+                      // expected-note {{base class 'const B1' specified here}}
   using T::T;
   G(int &) : G(0) {}
 };
 G<B1> g(123);
-G<const B1> g2(123);
+G<const B1> g2(123); // expected-note {{in instantiation of template class 'G<const B1>' requested here}}
diff --git a/clang/test/Sema/GH70594.cpp b/clang/test/Sema/GH70594.cpp
index ce98e9b12b5cba..91ec31f6b053cb 100644
--- a/clang/test/Sema/GH70594.cpp
+++ b/clang/test/Sema/GH70594.cpp
@@ -1,12 +1,11 @@
 // RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify
 // RUN: %clang_cc1 -fsyntax-only -std=c++23 %s -verify
 
-// expected-no-diagnostics
-
 struct A {};
 using CA = const A;
 
-struct S1 : CA {
+struct S1 : CA {           // expected-warning {{'const' qualifier on base class type 'CA' (aka 'const A') have no effect}} \
+                           // expected-note {{base class 'CA' (aka 'const A') specified here}}
   constexpr S1() : CA() {}
 };
 
@@ -14,15 +13,17 @@ struct S2 : A {
   constexpr S2() : CA() {}
 };
 
-struct S3 : CA {
+struct S3 : CA {          // expected-warning {{'const' qualifier on base class type 'CA' (aka 'const A') have no effect}} \
+                          // expected-note {{base class 'CA' (aka 'const A') specified here}}
   constexpr S3() : A() {}
 };
 
 struct Int {};
 
 template <class _Hp>
-struct __tuple_leaf : _Hp {
+struct __tuple_leaf : _Hp {           // expected-warning {{'const' qualifier on base class type 'const Int' have no effect}} \
+                                      // expected-note {{base class 'const Int' specified here}}
   constexpr __tuple_leaf() : _Hp() {}
 };
 
-constexpr __tuple_leaf<const Int> t;
+constexpr __tuple_leaf<const Int> t;  // expected-note {{in instantiation of template class '__tuple_leaf<const Int>' requested here}}
diff --git a/clang/test/SemaCXX/class-base-member-init.cpp b/clang/test/SemaCXX/class-base-member-init.cpp
index a6bb4410a81c84..e46c79a2b68b9c 100644
--- a/clang/test/SemaCXX/class-base-member-init.cpp
+++ b/clang/test/SemaCXX/class-base-member-init.cpp
@@ -103,7 +103,8 @@ namespace PR16596 {
   class A { public: virtual ~A(); };
   typedef const A Foo;
   void Apply(Foo processor);
-  struct Bar : public Foo {};
+  struct Bar : public Foo {}; // expected-warning {{'const' qualifier on base class type 'Foo' (aka 'const PR16596::A') have no effect}}\
+                              // expected-note {{base class 'Foo' (aka 'const PR16596::A') specified here}}
   void Fetch() {
     Apply(Bar());
   }
diff --git a/clang/test/SemaCXX/warn-base-type-qualifiers.cpp b/clang/test/SemaCXX/warn-base-type-qualifiers.cpp
new file mode 100644
index 00000000000000..5074140700cc36
--- /dev/null
+++ b/clang/test/SemaCXX/warn-base-type-qualifiers.cpp
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 %s -std=c++11 -Wignored-qualifiers -verify
+
+class A { };
+
+typedef const A A_Const;
+class B : public A_Const { }; // expected-warning {{'const' qualifier on base class type 'A_Const' (aka 'const A') have no effect}} \
+                              // expected-note {{base class 'A_Const' (aka 'const A') specified here}}
+
+typedef const volatile A A_Const_Volatile;
+class C : public A_Const_Volatile { }; // expected-warning {{'const volatile' qualifiers on base class type 'A_Const_Volatile' (aka 'const volatile A') have no effect}} \
+                                       // expected-note {{base class 'A_Const_Volatile' (aka 'const volatile A') specified here}}

…asses

clang/test/SemaCXX/warn-base-type-qualifiers.cpp

clang/lib/Sema/SemaDeclCXX.cpp

…/55474

clang/test/SemaCXX/warn-base-type-qualifiers.cpp

clang/lib/Sema/SemaDeclCXX.cpp

erichkeane

I have a bit of a concern that the template cases are going to be REALLY noisy, but we can deal with restricting individual use cases to a separate warning-group in the future if need-be.

a-tarasyuk · 2025-01-03T16:14:55Z

...that the template cases are going to be REALLY noisy

@erichkeane It looks like that's why I have two failed tests from llvm-libc++-shared-cfg-in due to the use of qualifiers

erichkeane · 2025-01-03T16:18:32Z

...that the template cases are going to be REALLY noisy

@erichkeane It looks like that's why I have two failed tests from llvm-libc++-shared-cfg-in due to the use of qualifiers

Yep, that looks to be exactly the case! I'd be interested to see if @ldionne would be willing to accept a std::remove_cv_t or something on those. This diagnostic is likely going to require/cause a level of const/volatile cleanliness in base classes that no one has ever really thought about before.

a-tarasyuk · 2025-01-12T22:20:33Z

@erichkeane @ldionne should the libcxx tests (common_reference.compile.pass.cpp, apply_extended_types.pass.cpp) be updated or should the new warnings/errors be treated as the new baseline?

erichkeane · 2025-01-13T14:41:40Z

@erichkeane @ldionne should the libcxx tests (common_reference.compile.pass.cpp, apply_extended_types.pass.cpp) be updated or should the new warnings/errors be treated as the new baseline?

This is entirely a @ldionne question, though I see in github that he's on vacation at the moment, so we'll have to wait until he returns.

ldionne · 2025-01-13T15:00:41Z

@erichkeane @ldionne should the libcxx tests (common_reference.compile.pass.cpp, apply_extended_types.pass.cpp) be updated or should the new warnings/errors be treated as the new baseline?

This is entirely a @ldionne question, though I see in github that he's on vacation at the moment, so we'll have to wait until he returns.

Thanks for the ping. I've returned but Github doesn't clear the vacation status automatically - fixed now.

This seems reasonable to me, we should "fix" libc++. I think this should do it:

diff --git a/libcxx/include/tuple b/libcxx/include/tuple
index aca14ba408d3..90257e9bae0a 100644
--- a/libcxx/include/tuple
+++ b/libcxx/include/tuple
@@ -257,6 +257,7 @@ template <class... Types>
 #  include <__type_traits/maybe_const.h>
 #  include <__type_traits/nat.h>
 #  include <__type_traits/negation.h>
+#  include <__type_traits/remove_cv.h>
 #  include <__type_traits/remove_cvref.h>
 #  include <__type_traits/remove_reference.h>
 #  include <__type_traits/unwrap_ref.h>
@@ -535,7 +536,7 @@ __memberwise_forward_assign(_Dest& __dest, _Source&& __source, __tuple_types<_Up
 
 template <class... _Tp>
 class _LIBCPP_TEMPLATE_VIS tuple {
-  typedef __tuple_impl<typename __make_tuple_indices<sizeof...(_Tp)>::type, _Tp...> _BaseT;
+  typedef __tuple_impl<typename __make_tuple_indices<sizeof...(_Tp)>::type, __remove_cv_t<_Tp>...> _BaseT;
 
   _BaseT __base_;

…/55474

… into feat/55474

erichkeane · 2025-01-14T15:14:53Z

As far as the CFE is concerned, we're OK with this. Though note, I anticipate quite a bit of push back as libraries discover this warning, though most should change their code instead, so I don't anticipate a good reason to revert.

erichkeane · 2025-01-21T15:33:43Z

@ldionne, @philnik777, other contributors: can you confirm that the small libcxx change in this patch is acceptable?

Thanks!

philnik777

This makes me wonder how many other instances like this there are in the wild in generic code, but I guess compressed_pair-style classes aren't that ubiquitous. LGTM.

erichkeane · 2025-01-21T15:50:06Z

This makes me wonder how many other instances like this there are in the wild in generic code, but I guess compressed_pair-style classes aren't that ubiquitous. LGTM.

TBH, I'm actually shocked that there is only 1 Libc++ violation of this warning. I was honestly quite positive that we'd see about a million there, plus another trillion in user code, as no one has ever really cared about this in the past.

I'm finding myself to be mildly optimistic here thanks to you guys only having 1 violation :)

Thanks for the review!

@a-tarasyuk : feel free to merge at your convenience.

llvm-ci · 2025-01-21T21:21:21Z

LLVM Buildbot has detected a new failure on builder openmp-offload-libc-amdgpu-runtime running on omp-vega20-1 while building clang,libcxx at step 7 "Add check check-offload".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12116

Here is the relevant piece of the build log for the reference

Step 7 (Add check check-offload) failure: test (failure)
******************** TEST 'libomptarget :: amdgcn-amd-amdhsa :: offloading/pgo1.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp    -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -nogpulib -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib  -fopenmp-targets=amdgcn-amd-amdhsa /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/offloading/pgo1.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/offloading/Output/pgo1.c.tmp -Xoffload-linker -lc -Xoffload-linker -lm /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib/libomptarget.devicertl.a -fprofile-instr-generate      -Xclang "-fprofile-instrument=clang"
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -nogpulib -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib -fopenmp-targets=amdgcn-amd-amdhsa /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/offloading/pgo1.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/offloading/Output/pgo1.c.tmp -Xoffload-linker -lc -Xoffload-linker -lm /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib/libomptarget.devicertl.a -fprofile-instr-generate -Xclang -fprofile-instrument=clang
# RUN: at line 3
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/offloading/Output/pgo1.c.tmp 2>&1 | /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/FileCheck /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/offloading/pgo1.c      --check-prefix="CLANG-PGO"
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/offloading/Output/pgo1.c.tmp
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/FileCheck /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/offloading/pgo1.c --check-prefix=CLANG-PGO
# .---command stderr------------
# | /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/offloading/pgo1.c:32:20: error: CLANG-PGO-NEXT: expected string not found in input
# | // CLANG-PGO-NEXT: [ 0 11 20 ]
# |                    ^
# | <stdin>:3:28: note: scanning from here
# | ======== Counters =========
# |                            ^
# | <stdin>:4:1: note: possible intended match here
# | [ 0 12 20 ]
# | ^
# | 
# | Input file: <stdin>
# | Check file: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/offload/test/offloading/pgo1.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |            1: ======= GPU Profile ======= 
# |            2: Target: amdgcn-amd-amdhsa 
# |            3: ======== Counters ========= 
# | next:32'0                                X error: no match found
# |            4: [ 0 12 20 ] 
# | next:32'0     ~~~~~~~~~~~~
# | next:32'1     ?            possible intended match
# |            5: [ 10 ] 
# | next:32'0     ~~~~~~~
# |            6: [ 20 ] 
# | next:32'0     ~~~~~~~
# |            7: ========== Data =========== 
# | next:32'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            8: { 9515997471539760012 4749112401 0xffffffffffffffd8 0x0 0x0 0x0 3 [...] 0 } 
# | next:32'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            9: { 3666282617048535130 24 0xffffffffffffffb0 0x0 0x0 0x0 1 [...] 0 } 
# | next:32'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            .
# |            .
# |            .
...

chapuni · 2025-01-22T04:31:52Z

Could we make bootstrapping warning-free before adding warnings?

https://lab.llvm.org/buildbot/#/builders/168/builds/7756

…124193) This resolves the `-Wignored-qualifiers` warning introduced by the new warnign in #121419. First caught in buildbot `ppc64le-lld-multistage-test` https://lab.llvm.org/buildbot/#/builders/168/builds/7756 --------- Co-authored-by: Henry Jiang <[email protected]>

…nternal.h (#124193) This resolves the `-Wignored-qualifiers` warning introduced by the new warnign in llvm/llvm-project#121419. First caught in buildbot `ppc64le-lld-multistage-test` https://lab.llvm.org/buildbot/#/builders/168/builds/7756 --------- Co-authored-by: Henry Jiang <[email protected]>

llvm/llvm-project#121419 added -Wignored-qualifiers diagnostic for cv-qualified base classes. This patch removes const from MockEthernetImpl to fix the -Wignored-qualifiers error. Bug: 391704289 Change-Id: I0d5bce970d6e91febe7a5f775b35b0b2e1383245 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1192542 Commit-Queue: Auto-Submit <[email protected]> Reviewed-by: Bruno Dal Bo <[email protected]> Fuchsia-Auto-Submit: Gulfem Savrun Yeniceri <[email protected]>

llvm/llvm-project#121419 added -Wignored-qualifiers diagnostic for cv-qualified base classes. This patch removes const from MockNetworkDeviceIfc to fix the -Wignored-qualifiers error similar to https://fxrev.dev/1192542. Bug: 391704289 Change-Id: I01fe73aa25850fa21d3ac10a14e894aed51e5419 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1194243 Fuchsia-Auto-Submit: Gulfem Savrun Yeniceri <[email protected]> Reviewed-by: Bruno Dal Bo <[email protected]> Commit-Queue: Auto-Submit <[email protected]>

llvm/llvm-project#121419 added -Wignored-qualifiers diagnostic for cv-qualified base classes. This patch removes const from MockEthernetImpl to fix the -Wignored-qualifiers error. Original-Bug: 391704289 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1192542 Original-Revision: 626de676a7b41c8be75aeb1fb7030735aa3f12d5 GitOrigin-RevId: fda0189e659871a285e713d06da62c0eaf8e7764 Change-Id: Iebcf36703ad221a3099d618e5ed14d9b048576c2

llvm/llvm-project#121419 added -Wignored-qualifiers diagnostic for cv-qualified base classes. This patch removes const from MockNetworkDeviceIfc to fix the -Wignored-qualifiers error similar to https://fxrev.dev/1192542. Original-Bug: 391704289 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1194243 Original-Revision: 49dbcd7dd9a6aedc8294cc2cf816727e25706294 GitOrigin-RevId: 3785f90762ae439b3034af9a0a072de315e20664 Change-Id: Ia059b5d0303ca0ed94c40ac4dcc1e34533807fbb

a-tarasyuk requested a review from Endilll as a code owner December 31, 2024 23:48

llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Dec 31, 2024

a-tarasyuk requested review from AaronBallman and erichkeane and removed request for Endilll December 31, 2024 23:48

a-tarasyuk force-pushed the feat/55474 branch 2 times, most recently from f3b5fc2 to 902d4f0 Compare January 1, 2025 13:03

[Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base cl…

3f6b1d6

…asses

a-tarasyuk force-pushed the feat/55474 branch from 902d4f0 to 3f6b1d6 Compare January 1, 2025 16:18

a-tarasyuk commented Jan 1, 2025

View reviewed changes

clang/test/SemaCXX/warn-base-type-qualifiers.cpp Outdated Show resolved Hide resolved

Fznamznon reviewed Jan 2, 2025

View reviewed changes

clang/lib/Sema/SemaDeclCXX.cpp Outdated Show resolved Hide resolved

a-tarasyuk added 2 commits January 2, 2025 17:06

use explicit variable type

3970973

Merge branch 'main' of https://github.com/llvm/llvm-project into feat…

3ffaa3a

…/55474

a-tarasyuk requested a review from Fznamznon January 2, 2025 15:08

erichkeane reviewed Jan 2, 2025

View reviewed changes

clang/test/SemaCXX/warn-base-type-qualifiers.cpp Outdated Show resolved Hide resolved

clang/test/SemaCXX/warn-base-type-qualifiers.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaDeclCXX.cpp Outdated Show resolved Hide resolved

eliminate template type constraint and add additional tests

3129f75

a-tarasyuk requested a review from erichkeane January 2, 2025 22:52

erichkeane approved these changes Jan 3, 2025

View reviewed changes

Merge branch 'main' into feat/55474

346e336

a-tarasyuk added 3 commits January 14, 2025 00:07

remove cv-qualifiers from inherited classes in tuple declaration

4da4f21

Merge branch 'main' of https://github.com/llvm/llvm-project into feat…

150a3db

…/55474

Merge branch 'feat/55474' of https://github.com/a-tarasyuk/llvm-project…

9463177

… into feat/55474

a-tarasyuk requested a review from a team as a code owner January 13, 2025 22:08

llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 13, 2025

a-tarasyuk added 4 commits January 14, 2025 10:33

Merge branch 'main' into feat/55474

e83daed

update tuple declaration

0c90ff8

Merge branch 'feat/55474' of https://github.com/a-tarasyuk/llvm-project…

ba6d791

… into feat/55474

Merge branch 'feat/55474' of https://github.com/a-tarasyuk/llvm-project…

9ef3687

… into feat/55474

a-tarasyuk force-pushed the feat/55474 branch from ce918f9 to 018d4fc Compare January 14, 2025 13:22

update tuple declaration

3aa2e5f

a-tarasyuk force-pushed the feat/55474 branch from 018d4fc to 3aa2e5f Compare January 15, 2025 00:05

a-tarasyuk requested a review from ldionne January 15, 2025 00:50

a-tarasyuk added 4 commits January 15, 2025 06:05

Merge branch 'main' into feat/55474

db7719f

Merge branch 'main' into feat/55474

096ec86

Merge branch 'main' into feat/55474

986922f

Merge branch 'main' into feat/55474

f9ddb2e

philnik777 approved these changes Jan 21, 2025

View reviewed changes

a-tarasyuk merged commit cac67d3 into llvm:main Jan 21, 2025
79 checks passed

mustartt mentioned this pull request Jan 23, 2025

[llvm][NFC] Remove CV-qualified base class in PassManagerInternal.h #124193

Merged

MagentaTreehouse mentioned this pull request Mar 18, 2025

[Clang][Diagnostics] Consider splitting warning on cv-qualified base classes into a separate group #131935

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes #121419

[Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes #121419

a-tarasyuk commented Dec 31, 2024

llvmbot commented Dec 31, 2024 •

edited

Loading

erichkeane left a comment

a-tarasyuk commented Jan 3, 2025

erichkeane commented Jan 3, 2025

a-tarasyuk commented Jan 12, 2025

erichkeane commented Jan 13, 2025

ldionne commented Jan 13, 2025

erichkeane commented Jan 14, 2025

erichkeane commented Jan 21, 2025

philnik777 left a comment

erichkeane commented Jan 21, 2025

llvm-ci commented Jan 21, 2025

chapuni commented Jan 22, 2025

[Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes #121419

[Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes #121419

Conversation

a-tarasyuk commented Dec 31, 2024

llvmbot commented Dec 31, 2024 • edited Loading

erichkeane left a comment

Choose a reason for hiding this comment

a-tarasyuk commented Jan 3, 2025

erichkeane commented Jan 3, 2025

a-tarasyuk commented Jan 12, 2025

erichkeane commented Jan 13, 2025

ldionne commented Jan 13, 2025

erichkeane commented Jan 14, 2025

erichkeane commented Jan 21, 2025

philnik777 left a comment

Choose a reason for hiding this comment

erichkeane commented Jan 21, 2025

llvm-ci commented Jan 21, 2025

chapuni commented Jan 22, 2025

llvmbot commented Dec 31, 2024 •

edited

Loading