[MIPS] [MSA] Widen v2i8, v216 and v2i32 vectors #123040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the undef deprecator. |
Cyanoxygen
force-pushed
the
cyan/mips-msa-widen-v2-vecs
branch
2 times, most recently
from
6643b64 to
ed98aec
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Cyanoxygen
force-pushed
the
cyan/mips-msa-widen-v2-vecs
branch
from
ed98aec to
4b42669
Compare
Cyanoxygen
changed the title
Cyanoxygen
changed the title
wzssyqa
reviewed
Jan 20, 2025
|
Can we split and |
No, the widened shuffle mask is guaranteed to contain UNDEFs which the VSHF must handle. Without that change the compiler simply aborts. |
Cyanoxygen
force-pushed
the
cyan/mips-msa-widen-v2-vecs
branch
from
4b42669 to
4e33b3e
Compare
|
TODO: Update test cases for mips32r5. For now the tests will fail. |
Cyanoxygen
force-pushed
the
cyan/mips-msa-widen-v2-vecs
branch
from
4e33b3e to
8fcfd7c
Compare
Cyanoxygen
force-pushed
the
cyan/mips-msa-widen-v2-vecs
branch
from
8fcfd7c to
44a4170
Compare
Currently v2i8, v2i16 and v2i32 are being promoted to v2i64 which casts the vector back and forth, and instructions with the wrong format are being used. Widening them to avoid unnecessary bitcasts, loads and stores, and ensure the correct element size is used. * tests/CodeGen/Mips: Update tests after widening of v2 vectors.
Currently VSHF does not handle UNDEF indices. However isSPLATI() is able to handle undefs, which may pass indices with undefs to this function. Adding a check to handle undefs in shuffle indices. Also, shuffle mask widened from v2 vector types are guranteed to contain UNDEFs. These shuffle lower logics can handle UNDEFs, so we just leave it as is, except for VSHF, which we must use whatever necessary to fill the UNDEFs.
Cyanoxygen
force-pushed
the
cyan/mips-msa-widen-v2-vecs
branch
from
44a4170 to
4bf95bc
Compare
|
@wzssyqa I've updated the change and the corresponding test cases based on the previous review comments. Could you please take a look at the new changes. |
wzssyqa
reviewed
Jan 24, 2025
| ; MIPS64R5EB-NEXT: shf.b $w0, $w0, 177 | ||
| ; MIPS64R5EB-NEXT: copy_s.h $1, $w0[0] | ||
| ; MIPS64R5EB-NEXT: sh $1, 44($sp) | ||
| ; MIPS64R5EB-NEXT: lh $2, 44($sp) |
There was a problem hiding this comment.
Another problem: why sh&lh here?
copy_s.h $2, $w0[0] ?
| ; MIPS64R5EB-NEXT: sh $5, 16($sp) | ||
| ; MIPS64R5EB-NEXT: sh $4, 0($sp) | ||
| ; MIPS64R5EB-NEXT: ld.b $w0, 16($sp) | ||
| ; MIPS64R5EB-NEXT: ld.b $w1, 0($sp) |
There was a problem hiding this comment.
Not a bug of this problem:
SH & LD.B may be optimistic with FILL or INSERT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ILVODwhen loweringVECTOR_SHUFFLE#123555.