Mc 37324: Add fallback to 'patch' command when 'git' command is not available #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable - Move exception handling from patch command implementations
…vailable - Fix unit test
…vailable - Add unit test
viktym
reviewed
Sep 22, 2020
src/Shell/Command/GitDriver.php
Outdated
| $this->processFactory->create(['git', 'apply', '--check'], $patch) | ||
| ->mustRun(); | ||
| } catch (ProcessFailedException $exception) { | ||
| throw new PatchCommandException('Patch cannot be applied', $exception->getCode(), $exception); |
There was a problem hiding this comment.
This error message contains Git error output that is parsed further
Actually here
We need to show the customer error details. Maybe it makes sense to add them in this class
…vailable - Remove -f flag in patch command - Fix services configuration
…vailable - Fix services configuration
…vailable - Fix error message formatting
…vailable - Remove formatErrorOutput
…vailable - Remove dead code
viktym
reviewed
Sep 24, 2020
| /** | ||
| * Git patch driver exception | ||
| */ | ||
| class GitDriverException extends DriverException |
There was a problem hiding this comment.
GitDriverException and PatchDriverException has the same implementation
Do we need them both? Or just use DriverException?
…vailable - Remove redundant exceptions
viktym
approved these changes
Sep 25, 2020
viktym
pushed a commit
that referenced
this pull request
Oct 14, 2020
…cloud-patches-78 [Imported] MC 37324: Add fallback to 'patch' command when 'git' command is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Manual testing scenarios
Release notes
For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Patches release notes.
Associated documentation updates
Add link to Magento DevDocs PR or Issue, if needed.
Contribution checklist