Feat/detail & scroll #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maitracle
reviewed
Apr 11, 2020
|
|
||
| if (selsoItem.isViewed) { | ||
| history.push('selso/detail'); | ||
| window.scrollTo(0, 0); |
Owner
There was a problem hiding this comment.
이거 list page에서 scroll to 해도 작동하나요??
detail page에서 mount 될 때 하는게 낫지 않을까요??
Collaborator
Author
There was a problem hiding this comment.
이게 시즌3할 때는 이렇게 했는데 mount 될 때 올리는게 더 깔끔하겠다!
웹으로는 무조건 올라가서 확인은 배포하고 모바일해서 켜보고 해봐야할듯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
detail 잘 불러오는 것 같아서 따로 수정이 필요한 것 같지가 않습니다.
나중에 백엔드에서 나이는 수정해서 보낼 것으로 생각하고 일단 bornYear만 불러옵니다.
추가로 중간부분에서 리스트 클릭시 최상단으로 올리도록 수정했습니다.
References
Checklist