Skip to content

Feat/detail & scroll #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Outwater wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feat/detail & scroll #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d27ece4
중복import제거
Outwater Mar 17, 2020
8b19455
Merge branch 'master' of https://github.com/maitracle/ting-front
Outwater Mar 20, 2020
38363fc
Merge branch 'master' of https://github.com/maitracle/ting-front
Outwater Mar 31, 2020
7ee94b2
Merge branch 'master' of https://github.com/maitracle/ting-front
Outwater Apr 6, 2020
035cae0
Merge branch 'master' of https://github.com/maitracle/ting-front
Outwater Apr 6, 2020
a88fd43
detail & scroll
Outwater Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/SelsoDetail/Card.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default ({ selsoDetail }) => {
<div className={styles.nicknameWrapper}>
<div className={styles.nickname}>{selsoDetail.nickname}</div>
<div className={styles.age}>
{selsoDetail.age}
{selsoDetail.profile?.bornYear}
살
</div>
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/modules/SelsoList/SelsoList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ const SelsoList = inject('selsoListStore', 'userStore')(observer(({ selsoListSto

if (selsoItem.isViewed) {
history.push('selso/detail');
window.scrollTo(0, 0);
Copy link
Owner

@maitracle maitracle Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 list page에서 scroll to 해도 작동하나요??

detail page에서 mount 될 때 하는게 낫지 않을까요??

Copy link
Collaborator Author

@Outwater Outwater Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 시즌3할 때는 이렇게 했는데 mount 될 때 올리는게 더 깔끔하겠다!
웹으로는 무조건 올라가서 확인은 배포하고 모바일해서 켜보고 해봐야할듯

} else {
setIsOpenSpendPointModal(true);
}
};

const spendPointAndMoveToDetailPage = () => {
history.push('selso/detail');
window.scrollTo(0, 0);
};

return (
Expand Down