Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the wait time for loading the chrome extensions #1255

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Jan 23, 2025

Closes #1223.

@d35ha d35ha self-assigned this Jan 23, 2025
@d35ha d35ha added this to the FLARE-VM 2025 Q1-P1 milestone Jan 23, 2025
@d35ha d35ha added the 💎 enhancement It is working, but it could be better label Jan 23, 2025
@d35ha d35ha requested a review from Ana06 January 23, 2025 17:26
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @d35ha! 👍

@@ -68,6 +68,9 @@ try {
$tries += 1
}

# Wait for an extra 60 seconds to make sure all extensions' tabs are opened already.
Start-Sleep -Seconds 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me like the time could be reduced a bit, but better to play it safe. 🤔

@Ana06 Ana06 merged commit b86fdc2 into mandiant:main Jan 23, 2025
4 checks passed
@Ana06 Ana06 removed this from the FLARE-VM 2025 Q1-P1 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome extensions open tabs
2 participants