Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the wait time for loading the chrome extensions #1255

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Extend the wait time for loading the chrome extensions #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/chrome.extensions.vm/chrome.extensions.vm.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
<metadata>
<id>chrome.extensions.vm</id>
<version>0.0.0.20240930</version>
<version>0.0.0.20250123</version>
<authors>Mandiant</authors>
<description>A package for multiple useful chrome extensions from the Chrome webstore.</description>
<dependencies>
Expand Down
3 changes: 3 additions & 0 deletions packages/chrome.extensions.vm/tools/chocolateyinstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ try {
$tries += 1
}

# Wait for an extra 60 seconds to make sure all extensions' tabs are opened already.
Start-Sleep -Seconds 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me like the time could be reduced a bit, but better to play it safe. 🤔


# Close Chrome gracefully.
if ($chromeProcess.CloseMainWindow())
{
Expand Down
Loading