Skip to content

Conversation

@yoshihiro503
Copy link
Contributor

@yoshihiro503 yoshihiro503 commented Jan 10, 2025

Motivation for this change

Source code looks:

Screenshot from 2025-01-10 13-17-27

Html doc looks:
Screenshot from 2025-01-10 13-17-46

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@proux01
Copy link
Collaborator

proux01 commented Jan 10, 2025

I'm lost, didn't we said that bullet lists would be easier to use?
Otherwise, for what it's worth, as far as I remember, if we want to save characters, the last | at the end of the line is not mandatory (as well as the space before the first one).

@affeldt-aist
Copy link
Member

I'm lost, didn't we said that bullet lists would be easier to use?

Yes, but also that we should try to use tables when reasonable.

@proux01
Copy link
Collaborator

proux01 commented Jan 10, 2025

Did we converge on some "definition" of reasonable?

@affeldt-aist
Copy link
Member

Did we converge on some "definition" of reasonable?

I think that "unreasonable" was implicitly defined as "when formatting is too painful because there are many RHS that require several lines each"

@affeldt-aist
Copy link
Member

Mmmhhh, I am concerned by the fact that the source file is much less readable.
In https://github.com/math-comp/analysis/blob/master/classical/classical_sets.v, we only used a table to format a summary of the documentation, and then providing the full documentation in verbatim centered lists (this was really just a test).
What about doing the same here? (LaTeXified digest at the top, and full doc in ASCII.)

@affeldt-aist
Copy link
Member

The last commit has restored the detailed documentation and kept the table as well, which acts a a digest of the detailed documentation: this provides an overview of the documentation while keeping the source code file readable.

@affeldt-aist
Copy link
Member

arg, the last commit was rejected, looks I do not have the rights to push @yoshihiro503

@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Feb 14, 2025
@affeldt-aist affeldt-aist added the documentation 📝 This issue/PR is about documentation of the library / repository label Feb 14, 2025
@affeldt-aist
Copy link
Member

@yoshihiro503 I PRed to your PR instead

separate digest from detailed documentation
@affeldt-aist affeldt-aist changed the title Doc: The definitions are expressed as a table. Doc: definitions expressed as a table in constructive_ereal.v Feb 15, 2025
@affeldt-aist affeldt-aist merged commit 7c82ae0 into math-comp:master Feb 18, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📝 This issue/PR is about documentation of the library / repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants