Skip to content

Conversation

@affeldt-aist
Copy link
Member

Motivation for this change

This PR provides four lemmas about derivation and near
that have been useful in InfoTheo
(https://github.com/affeldt-aist/infotheo/blob/8ac29a2e5cd8096b927daf38a00519af063f8d71/lib/derive_ext.v#L96) and also in the proof of L'Hopital's rule
(#1371).

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Feb 14, 2025
@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Feb 14, 2025
@affeldt-aist affeldt-aist mentioned this pull request Feb 14, 2025
2 tasks
@affeldt-aist
Copy link
Member Author

since these lemmas have been proved once by @t6s , once by me, and since we found at least two applications for them, we can maybe considered them as reviewed?

@t6s
Copy link
Member

t6s commented Feb 17, 2025

Any answer to my comments above, or do you want to keep and merge them as is?

@affeldt-aist
Copy link
Member Author

Sorry, I missed your comments. (Where are they?)

@t6s
Copy link
Member

t6s commented Feb 17, 2025

Sorry, they were just drafted, not submitted.

@affeldt-aist
Copy link
Member Author

Sorry, they were just drafted, not submitted.

No problem! Thanks. Will address ASAP.

@t6s
Copy link
Member

t6s commented Feb 17, 2025

(I've learned another piece of github usage)

Comment on lines 1890 to 1871
(f g : V -> W) (a v : V) : v != 0 -> {near a, f =1 g} ->
{near 0^', (fun h => h^-1 *: (f (h *: v + a) - f a)) =1
(fun h => h^-1 *: (g (h *: v + a) - g a))}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a simplification of this pending, I will submit it to you ASAP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of the release, is it ok to merge and to keep an issue open about the optimization of this proof?

@affeldt-aist affeldt-aist merged commit 762e08b into math-comp:master Feb 19, 2025
45 checks passed
@CohenCyril CohenCyril mentioned this pull request Feb 20, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants