Update he.js #68
Update he.js #68
Conversation
Corrected typo and new global detection
Syntax error
src/he.js
Outdated
| @@ -352,4 +352,4 @@ | |||
| root.he = he; | |||
| } | |||
|
|
|||
| }(this)); | |||
| }((new Function('return this))()); | |||
There was a problem hiding this comment.
Sadly, this won't work with most CSP headers.
There was a problem hiding this comment.
but at present it don't works with rollup
(!) this has been rewritten to undefined
https://rollupjs.org/guide/en#error-this-is-undefined
node_modules/he/he.js
}
}(this));There was a problem hiding this comment.
@mathiasbynens can you point me to a link where that is documented because at present i know no CSP that can affect that and at present its working well in production code cross browser plattform + even other javascript engines. greetings.
There was a problem hiding this comment.
There was a problem hiding this comment.
@mathiasbynens so when i understand you right. Your using this only in Web Extension Context that runs under Special CSP? So wehen we want to run it with the changes we need to fork?
There was a problem hiding this comment.
No, CSP can be used on any web page. Thus, using Function is not an option.
Can we look at another way of fixing this?
There was a problem hiding this comment.
@mathiasbynens the more big problem is not only this lib we use same tech in much bigger JS Frameworks to get a environment agnostic global. Examples Angular, React, we use it all over. Maybe i need then to write a TC for EMCA/JS to Offer a Shared Global Object with always the same accessor.
But at present in our real world scenarios we have zero issues. In Realworld this method is the best way without 100 of if then checks to get the global object we are running in
There was a problem hiding this comment.
That proposal already exists: https://github.com/tc39/proposal-global I've implemented it in V8. :)
Fix little typo
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 1 1
Lines 156 156
=======================================
Hits 151 151
Misses 5 5Continue to review full report at Codecov.
|
And Again reduced the call level
Final Test else let it be undefined ;)
Corrected typo and new global detection