Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update he.js #68

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update he.js #68

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ac8ffc
Update he.js
frank-dspeed Oct 15, 2018
b512f72
Update he.js
frank-dspeed Oct 15, 2018
924ddec
Update he.js
frank-dspeed Oct 19, 2018
ce8b8f3
Update he.js
frank-dspeed Oct 19, 2018
cc217f6
Update he.js
frank-dspeed Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/he.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*! https://mths.be/he v<%= version %> by @mathias | MIT license */
;(function(root) {
(function(root) {

// Detect free variables `exports`.
var freeExports = typeof exports == 'object' && exports;
Expand Down Expand Up @@ -352,4 +352,4 @@
root.he = he;
}

}(this));
}((new Function('return this))());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this won't work with most CSP headers.

Copy link
Author

@frank-dspeed frank-dspeed Oct 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but at present it don't works with rollup
(!) this has been rewritten to undefined
https://rollupjs.org/guide/en#error-this-is-undefined
node_modules/he/he.js

   }
 }(this));

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathiasbynens can you point me to a link where that is documented because at present i know no CSP that can affect that and at present its working well in production code cross browser plattform + even other javascript engines. greetings.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frank-dspeed https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Content_Security_Policy#eval%28%29_and_friends

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathiasbynens so when i understand you right. Your using this only in Web Extension Context that runs under Special CSP? So wehen we want to run it with the changes we need to fork?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, CSP can be used on any web page. Thus, using Function is not an option.

Can we look at another way of fixing this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathiasbynens the more big problem is not only this lib we use same tech in much bigger JS Frameworks to get a environment agnostic global. Examples Angular, React, we use it all over. Maybe i need then to write a TC for EMCA/JS to Offer a Shared Global Object with always the same accessor.

But at present in our real world scenarios we have zero issues. In Realworld this method is the best way without 100 of if then checks to get the global object we are running in

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That proposal already exists: https://github.com/tc39/proposal-global I've implemented it in V8. :)