Skip to content

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 18, 2025

This adds partial support for matrix-org/matrix-spec-proposals#4359 and suppresses push notifications when a room is set to "Do not Disturb" (DnD). The DnD setting is sourced from a dedicated global account data event.

  • Public API changes documented in changelogs (optional)

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.40%. Comparing base (943b048) to head (1292755).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5687   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         359      359           
  Lines       99060    99063    +3     
  Branches    99060    99063    +3     
=======================================
+ Hits        87570    87573    +3     
+ Misses       7353     7351    -2     
- Partials     4137     4139    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 18, 2025

CodSpeed Performance Report

Merging #5687 will not alter performance

Comparing Johennes:johannes/msc4359 (1292755) with main (bbeb2d2)

Summary

✅ 50 untouched

@Johennes Johennes force-pushed the johannes/msc4359 branch 2 times, most recently from eee8a98 to 7118250 Compare September 30, 2025 12:00
@Johennes Johennes changed the title feat(push): add experimental support for MSC4359 ("Do not Disturb" notification settings) feat(push): add experimental support for applying "Do not Disturb" notification settings as per MSC4359 Sep 30, 2025
@Johennes Johennes marked this pull request as ready for review September 30, 2025 12:51
@Johennes Johennes requested a review from a team as a code owner September 30, 2025 12:51
@Johennes Johennes requested review from bnjbvr and removed request for a team September 30, 2025 12:51
…sturb" notification settings)

Signed-off-by: Johannes Marbach <[email protected]>
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Johennes, thanks for the contribution! I'm not against it in principle, but we're a bit concerned that adding support for experimental features like this adds significantly to the maintenance overhead of matrix-rust-sdk, and as such feel like it's probably a bit early to merge support for this into mainline, even when guarded by feature flags. Perhaps you could keep it in a fork for now, and we can revisit once the MSC (or the other) gets a bit more traction?

@Johennes
Copy link
Contributor Author

Johennes commented Oct 2, 2025

Oh. 😯 This actually seemed relatively minimal to me, especially when compared to its predecessor #5441. I understand the rationale though and keeping this in a fork is fine. If it's ok, I'll leave this pull request open in draft state because it's currently the only public implementation of the MSC.

@Johennes Johennes marked this pull request as draft October 2, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants