Skip to content

MSC4359: "Do not Disturb" notification settings #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MSC4359: "Do not Disturb" notification settings #4359

wants to merge 1 commit into from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 17, 2025 •
edited
Loading

@Johennes Johennes changed the title MSCXXXX: "Do not Disturb" notification settings MSC4359: "Do not Disturb" notification settings Sep 17, 2025
@Johennes Johennes marked this pull request as ready for review September 17, 2025 16:57
@Johennes Johennes mentioned this pull request Sep 17, 2025
Merged
@turt2live turt2live added push proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 17, 2025
turt2live
turt2live reviewed Sep 17, 2025
View reviewed changes
proposals/4359-do-not-disturb.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • Client
  • Server

Copy link
Contributor Author

@Johennes Johennes Sep 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruma (account-wide setting): ruma/ruma#2221
Rust SDK (account-wide setting): matrix-org/matrix-rust-sdk#5687

@Johennes Johennes mentioned this pull request Sep 18, 2025
Draft
1 task
benkuly
benkuly reviewed Sep 19, 2025
View reviewed changes
proposals/4359-do-not-disturb.md

## Alternatives

[MSC3768] integrates DnD into the existing push rule system. This significantly increases the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a cleaner way, because it won't introduce a new parallel approach. I also think it would be way easier to implement and test. At least on the client side in Trixnity and Trixnity Messenger, where I'm currently implementing notifications from scratch up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue I ran into when implementing MSC3768 is https://github.com/matrix-org/matrix-spec-proposals/pull/3768/files#r2348952758.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

+1 more reviewer

@benkuly benkuly benkuly left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal push
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Johennes @turt2live @benkuly