Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty pre-release v1- results in malformed version 1.0.0- #11

Closed
josephearl opened this issue Apr 22, 2024 · 1 comment
Closed

Empty pre-release v1- results in malformed version 1.0.0- #11

josephearl opened this issue Apr 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@josephearl
Copy link
Contributor

josephearl commented Apr 22, 2024 •
edited
Loading

Currently this action will parse a malformed pre-release, e.g. v1- as version 1.0.0- with an empty extra.

I think this should either be invalid, or coerce to a version of 1.0.0.
@josephearl josephearl mentioned this issue Apr 22, 2024
Merged
@josephearl josephearl changed the title Empty pre-release should result in an error instead of parsing Empty pre-release v1- results in malformed version 1.0.0- Apr 22, 2024
@matt-usurp matt-usurp added the bug Something isn't working label Apr 23, 2024
@matt-usurp
Copy link
Owner

Fix available in https://github.com/matt-usurp/validate-semver/releases/tag/v2.1.0 and on the v2 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matt-usurp @josephearl