Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build info #14

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat: add build info #14

merged 1 commit into from
Apr 23, 2024

Conversation

josephearl
Copy link
Contributor

@josephearl josephearl commented Apr 22, 2024

Adds a build output property with the build information. Fixes #10 and also #11.

Should extra be renamed to prerelease for consistency with SemVer terminology? (or perhaps have both for backwards compatibility?)

@matt-usurp
Copy link
Owner

matt-usurp commented Apr 23, 2024

Hey, thanks for this.

You know I wasn't aware of the "build" information, I only added the "extra" stuff because I wasn't aware if it was supported, but if its part of the semantic versioning specification (which it is, and the package supports) then I am happy with it. Appreciate the extra tests too. This makes me realise I should have some documentation for building the action (which I see you have done, so thanks too)

Should extra be renamed to prerelease for consistency with SemVer terminology? (or perhaps have both for backwards compatibility?)

I agree, if there is terminology here that makes more sense and follows the specification then I am all for it. So preferably the latter with it being replaced in the README and just marked as to be removed in the code for >=v3 with a comment.

@matt-usurp matt-usurp added bug Something isn't working enhancement New feature or request labels Apr 23, 2024
@matt-usurp matt-usurp self-requested a review April 23, 2024 09:32
@josephearl
Copy link
Contributor Author

Have updated the PR to add prerelease as an output and replaced extra with prerelease in the documentation as suggested.

Copy link
Owner

@matt-usurp matt-usurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matt-usurp matt-usurp merged commit 7bbc958 into matt-usurp:main Apr 23, 2024
1 check passed
@matt-usurp
Copy link
Owner

Release https://github.com/matt-usurp/validate-semver/releases/tag/v2.1.0 and also on v2 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build information
2 participants