Intl.Locale updates

[jahzielv]

A checklist to help your pull request get merged faster:

• Summarize your changes
• Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
• Data: if you tested something, describe how you tested with details like browser and version
• Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
• Link to related issues or pull requests, if any

This PR aims to add browser compat data for Intl.Locale and its various properties. This is part of a documentation effort involving Daniel Ehrenberg, Romulo Cintra, and myself. We're tracking our progress here.

npm test runs cleanly and Travis builds successfully.

According to my research, Chrome (desktop, Android, and WebView) is the only browser with support currently (shipped in Chrome 74). Firefox and Edge have issues open and are in development, but have not implemented yet. Safari hasn't issued any public signals regarding Intl.Locale.

Properties of Intl.Locale to add compat data for:

• prototype
• minimize()
• maximize()
• toString()
• baseName
• calendar
• collation
• hourCycle
• caseFirst
• numeric
• numberingSystem
• language
• script
• region
  Cheers!

[jahzielv]

Edit note: I added a list of all the properties of Intl.Locale and whether or not I've added compat data for them. I'll be adding data over the coming days!

[queengooborg]

All the data is looking good to me! A little pro tip with Chromium browsers: since Opera 15 (and Opera Android 14), Opera adapted Chrome's engine into its own. For Opera desktop, the version numbers can be identified based upon the following formula: min(15, CHROME_VERSION - 13). (Opera Android was like that until version 43 -- I've included a mapping in my pull request to add engine versions). Samsung Internet's also Chrome-based, but for now, we just set it to true or false.

Regarding all the properties, would you like to add them in a single PR and wait for us to merge it until it's all done, or would you rather us merge this as it is and work on additional PRs?

[jahzielv]

Thanks for the tips @vinyldarkscratch! As far as the properties go, I think I'll add them all on this PR and then we can merge them all at once. I'll be offline this week, but should have some time Saturday to get back on this. Thanks!

[queengooborg]

Alright, sounds like a plan! I’ll mark this as “not ready” for the time being. 😉

[jahzielv]

@vinyldarkscratch regarding your tip about Opera: Taking a look at this version history, it seems like the latest version (Opera 60) uses Chromium 73, which wouldn't support Intl.Locale. Could you elaborate a bit on what you meant by

For Opera desktop, the version numbers can be identified based upon the following formula: min(15, CHROME_VERSION - 13). (Opera Android was like that until version 43 -- I've included a mapping in my pull request to add engine versions). Samsung Internet's also Chrome-based, but for now, we just set it to true or false.

? Thanks for your help with this!

[queengooborg]

Sorry, you can totally ignore that part! I wrote that before I found out Opera 61 and 62 are only beta versions. 😛

[jahzielv]

Cool cool thanks!

[jahzielv]

All data has been added! npm test runs cleanly, but I have a question about the rendering. When I run a render test, the resulting table looks like this:

The data is correct, but the table isn't styled correctly. Am I missing something in the command? I ran

npm run render javascript.builtins.Intl.Locale.script

[queengooborg]

Don't mind the old styling with npm run render, efforts to get it to use the new styling sheet are in #736 and #737. Thanks for your hard work on this PR! I'll be reviewing it shortly. 😉

[queengooborg]

All in all, looks good! Just one small change to make.

[jahzielv]

Order has been updated! 🎉

[queengooborg]

Looking good to me, thank you! Just made the change to the wiki that will add this BCD in as well in the next Kumascript release. 😉

[jahzielv]

Woot woot - thanks for your help!