Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Docs(MDN) Documentation for Intl.Locale #70

Closed
14 tasks done
romulocintra opened this issue Mar 19, 2019 · 17 comments
Closed
14 tasks done

Docs(MDN) Documentation for Intl.Locale #70

romulocintra opened this issue Mar 19, 2019 · 17 comments

Comments

@romulocintra
Copy link
Member

romulocintra commented Mar 19, 2019

Create Documentation for ** Intl.Locale**

  • Review Readme documentation and examples
  • Create MDN Main Docs Page Link

MDN Pages :

  • prototype
  • constructor
  • methods
  • properties

Interactive Examples MDN :

  • Locale Generic Usage
  • Locale.prototype.maximize ()
  • Locale.prototype.minimize ()
  • Locale.prototype.toString ()

Browser compat-data :

  • Locale Generic Usage
  • Locale.prototype.maximize ()
  • Locale.prototype.minimize ()
  • Locale.prototype.toString ()
@romulocintra
Copy link
Member Author

@littledan probably this should have some priority due is shipping in Chrome74 correct ?! Shall we start working?

@littledan
Copy link
Member

Yes, this is a good idea.

@jahzielv
Copy link

Added Intl.Locale to list of constructors here

@jahzielv
Copy link

Created Intl.Locale.prototype page, still have to add in some descriptions for properties and methods.

@romulocintra
Copy link
Member Author

romulocintra commented May 2, 2019

Created Intl.Locale.prototype page, still have to add in some descriptions for properties and methods.

Just updated TODO list :) thanks a lot for your work

@jahzielv
Copy link

jahzielv commented May 2, 2019

Created the prototype.minimize, prototype.maximize, and prototype.toString pages! Will be adding content to them over today and next several days.

@jahzielv
Copy link

jahzielv commented May 2, 2019

Just opened up a PR with browser-compat-data! mdn/browser-compat-data#4052

@jahzielv
Copy link

Just a heads up that this page (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Locale) is the main docs page as well as the constructor page, so we can check that off the list.

@jahzielv
Copy link

jahzielv commented May 18, 2019

All the properties as well as the methods now have MDN pages! Additionally, I've added all the compat data to the PR I've opened. There's a small testing snag to be worked out, but once that's fixed it should be ready to land. I'd appreciate another pair of eyes to review that PR and make sure that I did my research on other browsers' compatibility correctly. I'll be adding the content over the coming days!

@jahzielv
Copy link

PR for browser-compat has landed! mdn/browser-compat-data#4052 🎉🎉

@jahzielv
Copy link

jahzielv commented Jul 5, 2019

@romulocintra All the browser compat and MDN pages have been added. Only thing left are the interactive examples!

@jahzielv
Copy link

jahzielv commented Jul 6, 2019

PRs submitted for toString, minimize, and maximize interactive examples! More to follow for other properties.

@jahzielv
Copy link

toString, minimize, and maximize interactive example PRs have landed! @romulocintra do we need interactive examples for all the non-function properties as well? If so, my goal will be to have them done by the end of next week but just want to make sure those are required.

@romulocintra
Copy link
Member Author

Great job @jahzielv 🥇 .

Probably would be great to have an Interactive example in the Intl.Locale Main Page and some more brief explanation before going to details page from each method/api.

Probably I would follow the example of RelativeTimeFormat That covers the surface of the API then redirects to specific pages.

What do you think about? Should I close the issue ?

Great Job again and thanks to pushing this forward.

@jahzielv
Copy link

Thanks! I've really appreciated the opportunity to work with ECMA on this effort and look forward to the next project!

Probably I would follow the example of RelativeTimeFormat That covers the surface of the API then redirects to specific pages.

Sounds good! I'll take a look and add the IE asap.

What do you think about? Should I close the issue ?

Once I finish up the example for the main page, I think we can close! All pages have had the "Draft" status removed from them, so I think that's the last thing before we can wrap this one up!

@jahzielv
Copy link

WOOHOO the last interactive example has been merged! Just added it to the Locale page. I believe that completes this documentation project! 🎉🎊🥳

@romulocintra
Copy link
Member Author

Thanks all for the effort ;) closing the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants